[es6] Map/Set size getter should have "get size" name

[es6] Map/Set size getter should have "get size" name

Getter and setter function names in ES6 are defined as "get foo" and
"set foo".

BUG=None
LOG=N
R=adamk@chromium.org

Committed: https://crrev.com/83c89a2e71a363afb35595f903423e650d788e42
Cr-Commit-Position: refs/heads/master@{#28034}

[arv (Not doing code reviews), 2015-04-23 18:18:49]

PTAL

[adamk, 2015-04-23 18:20:15]

lgtm

[caitp (gmail), 2015-04-23 18:21:52]

On 2015/04/23 18:20:15, adamk wrote:
> lgtm

just an idea, but what if we changed the InstallGetter helper instead? (and the
other accessor-related helpers)

[arv (Not doing code reviews), 2015-04-23 18:25:40]

On 2015/04/23 18:21:52, caitp wrote:
> On 2015/04/23 18:20:15, adamk wrote:
> > lgtm
> 
> just an idea, but what if we changed the InstallGetter helper instead? (and
the
> other accessor-related helpers)

I like that. Doin' it!

[arv (Not doing code reviews), 2015-04-23 19:14:26]

Make InstallGetter and InstallGetterSetter handle the name

[arv (Not doing code reviews), 2015-04-23 19:18:56]

Moved the logic to InstallGetter and InstallGetterSetter instead.

PTAL

https://codereview.chromium.org/1094323005/diff/20001/test/mjsunit/es6/built-...
File test/mjsunit/es6/built-in-accessor-names.js (right):

https://codereview.chromium.org/1094323005/diff/20001/test/mjsunit/es6/built-...
test/mjsunit/es6/built-in-accessor-names.js:18: 
These are all the cases of InstallGetter and InstallGetterSetter in our code
base.

[arv (Not doing code reviews), 2015-04-23 19:19:06]

Patchset #2 (id:20001) has been deleted

[caitp (gmail), 2015-04-23 19:23:45]

caitpotter88@gmail.com changed reviewers:
+ caitpotter88@gmail.com

[caitp (gmail), 2015-04-23 19:23:46]

lgtm, but some comments might be worth consideration

https://codereview.chromium.org/1094323005/diff/40001/src/v8natives.js
File src/v8natives.js (right):

https://codereview.chromium.org/1094323005/diff/40001/src/v8natives.js#newcode49
src/v8natives.js:49: %FunctionSetName(getter, `get ${
templates makes it look more readable, but remember the ToString() calls are
potentially slow down bootstrapping a bit. Not sure how significantly though.

[arv (Not doing code reviews), 2015-04-23 19:50:34]

Remove template literals

[arv (Not doing code reviews), 2015-04-23 19:51:53]

PTAL

https://codereview.chromium.org/1094323005/diff/40001/src/v8natives.js
File src/v8natives.js (right):

https://codereview.chromium.org/1094323005/diff/40001/src/v8natives.js#newcode49
src/v8natives.js:49: %FunctionSetName(getter, `get ${
On 2015/04/23 19:23:45, caitp wrote:
> templates makes it look more readable, but remember the ToString() calls are
> potentially slow down bootstrapping a bit. Not sure how significantly though.

Changed to +. It does not get too ugly.

[caitp (gmail), 2015-04-23 19:57:22]

On 2015/04/23 19:51:53, arv wrote:
> PTAL
> 
> https://codereview.chromium.org/1094323005/diff/40001/src/v8natives.js
> File src/v8natives.js (right):
> 
>
https://codereview.chromium.org/1094323005/diff/40001/src/v8natives.js#newcode49
> src/v8natives.js:49: %FunctionSetName(getter, `get ${
> On 2015/04/23 19:23:45, caitp wrote:
> > templates makes it look more readable, but remember the ToString() calls are
> > potentially slow down bootstrapping a bit. Not sure how significantly
though.
> 
> Changed to +. It does not get too ugly.

It looks ok to me. The speed difference probably isn't significant, but I guess
there's a bit less work this way

[adamk, 2015-04-23 19:59:37]

lgtm

[arv (Not doing code reviews), 2015-04-23 20:05:34]

The CQ bit was checked by arv@chromium.org

[arv (Not doing code reviews), 2015-04-23 20:05:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
caitpotter88@gmail.com
Link to the patchset: https://codereview.chromium.org/1094323005/#ps60001
(title: "Remove template literals")

[commit-bot: I haz the power, 2015-04-23 20:05:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1094323005/60001

[commit-bot: I haz the power, 2015-04-23 20:29:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-23 20:29:29]

Try jobs failed on following builders:
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/5115)

[arv (Not doing code reviews), 2015-04-23 21:11:40]

Make sure the function name is flattened

[arv (Not doing code reviews), 2015-04-23 21:13:25]

The debug bots failed because the function name was not flattened. I've added a
call to String::Flatten and the tests pass locally now.

[arv (Not doing code reviews), 2015-04-23 21:13:28]

The CQ bit was checked by arv@chromium.org

[arv (Not doing code reviews), 2015-04-23 21:13:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
caitpotter88@gmail.com, adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/1094323005/#ps80001
(title: "Make sure the function name is flattened")

[commit-bot: I haz the power, 2015-04-23 21:13:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1094323005/80001

[commit-bot: I haz the power, 2015-04-23 21:56:38]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-04-23 21:56:45]

Patchset 4 (id:??) landed as
https://crrev.com/83c89a2e71a363afb35595f903423e650d788e42
Cr-Commit-Position: refs/heads/master@{#28034}

[arv (Not doing code reviews), 2015-04-23 22:06:24]

A revert of this CL (patchset #4 id:80001) has been created in
https://codereview.chromium.org/1106713002/ by arv@chromium.org.

The reason for reverting is: Breaks GCMole ia32

http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gcmole/builds...


src/runtime/runtime-function.cc:96:3: warning: Possible problem with evaluation
order.
  f->shared()->set_name(*NameToFunctionName(name));
  ^
src/runtime/runtime-function.cc:96:3: warning: Possible problem with evaluation
order.
2 warnings generated..