Issue 1094313003: Revert of track global accesses to constant types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1094313003: Revert of track global accesses to constant types (Closed)

Created:
5 years, 8 months ago by Michael Achenbach

Modified:
5 years, 8 months ago

Reviewers:
dcarney, Toon Verwaest

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of track global accesses to constant types (patchset #15 id:280001 of https://codereview.chromium.org/1062163005/) Reason for revert: [Sheriff] Speculative revert for maybe breaking layout tests, e.g. http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2032/builds/2589 Will reland if it doesn't help. Original issue's description: > track global accesses to constant types > > BUG= TBR=verwaest@chromium.org,dcarney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/99743486743c19d6dc45f59808b53da01ec1e958 Cr-Commit-Position: refs/heads/master@{#27982}

Created: 5 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -219 lines)			Patch
M	src/code-stubs.h	View	3 chunks	+20 lines, -28 lines	0 comments	Download
M	src/code-stubs-hydrogen.cc	View	3 chunks	+8 lines, -39 lines	0 comments	Download
M	src/hydrogen.cc	View	4 chunks	+7 lines, -64 lines	0 comments	Download
M	src/ic/ic.cc	View	2 chunks	+5 lines, -10 lines	0 comments	Download
M	src/lookup.h	View	2 chunks	+5 lines, -6 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/objects.cc	View	13 chunks	+22 lines, -51 lines	0 comments	Download
M	src/property-details.h	View	2 chunks	+7 lines, -19 lines	0 comments	Download

Total messages: 4 (0 generated)

Michael Achenbach

Created Revert of track global accesses to constant types

5 years, 8 months ago (2015-04-21 18:02:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094313003/1

5 years, 8 months ago (2015-04-21 18:03:03 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-22 04:10:44 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/99743486743c19d6dc45f59808b53da01ec1e958
Cr-Commit-Position: refs/heads/master@{#27982}