Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 10943: Wire Regexp2000 up to the normal JS RegExp object. (Closed)

Created:
12 years, 1 month ago by Erik Corry
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Wire Regexp2000 up to the normal JS RegExp object. Committed: http://code.google.com/p/v8/source/detail?r=753

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -113 lines) Patch
M src/factory.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/jsregexp.h View 13 chunks +68 lines, -24 lines 0 comments Download
M src/jsregexp.cc View 23 chunks +266 lines, -83 lines 2 comments Download
M src/objects.h View 3 chunks +9 lines, -3 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/test-regexp.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
12 years, 1 month ago (2008-11-14 08:34:53 UTC) #1
Lasse Reichstein
12 years, 1 month ago (2008-11-14 10:03:39 UTC) #2
LGTM

http://codereview.chromium.org/10943/diff/1/7
File src/jsregexp.cc (right):

http://codereview.chromium.org/10943/diff/1/7#newcode649
Line 649: ASSERT_EQ(regexp->TypeTag(), JSRegExp::RE2K);
This method looks like an almost, but not entirely, complete copy of
JsreExecGlobal. Could some of it be abstracted into one function?

http://codereview.chromium.org/10943/diff/1/7#newcode821
Line 821: int capture_count) {
Also need to know if we ignore case.

Powered by Google App Engine
This is Rietveld 408576698