Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: lib/src/codegen/js_codegen.dart

Issue 1094243007: Fix Array constructor bug impacting dart2js and ddc running on the same page. (Closed) Base URL: git@github.com:dart-lang/dart-dev-compiler.git@master
Patch Set: ptal Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart_runtime.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/codegen/js_codegen.dart
diff --git a/lib/src/codegen/js_codegen.dart b/lib/src/codegen/js_codegen.dart
index 85b42aa56d42f9ca351932e4bee14d862c65b40a..b574bcf1550f2d1c3559b5a6da22a39adfbe8998 100644
--- a/lib/src/codegen/js_codegen.dart
+++ b/lib/src/codegen/js_codegen.dart
@@ -357,7 +357,7 @@ class JSCodegenVisitor extends GeneralizingAstVisitor with ConversionVisitor {
// want to support construction of instances with generic types other
// than dynamic. See issue #154 for Array and List<E> related bug.
var copyMembers = js.statement(
- 'dart.copyProperties(dart.global.#.prototype, #.prototype);', [
+ 'dart.registerExtension(dart.global.#, #);', [
_propertyName(jsPeerName),
classElem.name
]);
« no previous file with comments | « lib/runtime/dart_runtime.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698