Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 1094243007: Fix Array constructor bug impacting dart2js and ddc running on the same page. (Closed)

Created:
5 years, 8 months ago by Jacob
Modified:
5 years, 8 months ago
Reviewers:
jmesserly, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dart-dev-compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix Array constructor bug impacting dart2js and ddc running on the same page. BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/c1824da0666989637d4b016d0e56f0cefdd296c1

Patch Set 1 #

Total comments: 3

Patch Set 2 : ptal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M lib/runtime/dart/core.js View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart_runtime.js View 1 1 chunk +20 lines, -4 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
5 years, 8 months ago (2015-04-23 19:20:03 UTC) #2
Jennifer Messerly
lgtm https://codereview.chromium.org/1094243007/diff/1/lib/runtime/dart/core.js File lib/runtime/dart/core.js (right): https://codereview.chromium.org/1094243007/diff/1/lib/runtime/dart/core.js#newcode1619 lib/runtime/dart/core.js:1619: dart.copyPropertySymbols(dart.global.Array.prototype, List.prototype); dart.registerExtension(dart.global.Array, List)? we might need this ...
5 years, 8 months ago (2015-04-23 19:33:54 UTC) #4
Jacob
5 years, 8 months ago (2015-04-23 20:19:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c1824da0666989637d4b016d0e56f0cefdd296c1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698