Resolve op when op= syntax is used.

lib/compiler/implementation/resolver.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 abstract class TreeElements {
   Element operator[](Node node);
   Selector getSelector(Send send);
   DartType getType(TypeAnnotation annotation);
   bool isParameterChecked(Element element);
 }
@@ skipping 1531 matching lines @@
         // TODO(kasperl): If [getter] is resolved, it will actually
         // refer to the []= operator which isn't the one we want to
         // register here. We should consider using some notion of
         // abstract indexable element that we can resolve to so we can
         // distinguish the two.
         assert(selector.isIndexSet());
         registerSend(new Selector.index(), null);
       }
 
       // Make sure we include the + and - operators if we are using
-      // the ++ and -- ones.
+      // the ++ and -- ones.  Also, if op= form is used, include op itself.
       void registerBinaryOperator(SourceString name) {
         Selector binop = new Selector.binaryOperator(name);
         world.registerDynamicInvocation(binop.name, binop);
       }
       if (source === '++') registerBinaryOperator(const SourceString('+'));
       if (source === '--') registerBinaryOperator(const SourceString('-'));
+      if (source.endsWith('=')) {
+        registerBinaryOperator(new SourceString(source));

[ahe, 2012/09/24 09:19:31]

This will register '+=' as a binary operator. But '+=' is not a binary operator.

[Anton Muhin, 2012/09/24 09:22:30]

That's somewhat surprising, but it actually works as Selector.binaryOperator
invokes Elements.constructOperatorName which in it's turn translates op= strings
to op.

On 2012/09/24 09:19:31, ahe wrote:

[ahe, 2012/09/24 11:14:55]

I agree this is surprising, and I don't think this should be happening. I would
have cleaned this up a long time ago if I hadn't been behind on language
features.

On 2012/09/24 09:22:30, Anton Muhin wrote:

[Anton Muhin, 2012/09/24 13:13:07]

Peter, you should know this stuff better.

Anyway, may I proceed with my CL?  I'd rather fix the problem we have with
dart2dart.  Any other solution seems even worse than this one.

On 2012/09/24 11:14:55, ahe wrote:

[ahe, 2012/09/24 13:22:24]

dart2dart is not a short-term priority, so we can take the time to do it right.

[Anton Muhin, 2012/09/24 13:23:31]

What would be your advice then

On 2012/09/24 13:22:24, ahe wrote:

[ahe, 2012/09/24 13:50:30]

Create a method that maps a compound operator to its corresponding
user-definable operator.

I already have a CL that does that: http://codereview.chromium.org/10905211/

Right now, landing that CL is not a priority for me. Updating co19 and
implementing M1 language features is. So if you cannot wait for me to land the
CL, I suggest you hack around this in dart2dart by registering all operators up
front.


On 2012/09/24 13:23:31, Anton Muhin wrote:

[ahe, 2012/09/24 16:07:55]

Or even better: take Elements.mapToUserOperator from CL 10905211 and use it
here.

You should notice that the original source string already exists, see line 1503.

So try something like this on line 1503:

SourceString operatorName = node.assignmentOperator.source;
String source = operatorName.stringValue;

And then here use this:

registerBinaryOperator(Elements.mapToUserOperator(operatorName));

On 2012/09/24 13:50:30, ahe wrote:

[Anton Muhin, 2012/09/24 16:09:18]

Thanks a lot, Peter, let me give it a try.

On 2012/09/24 16:07:55, ahe wrote:

[Anton Muhin, 2012/09/25 10:05:51]

Done, ptal

On 2012/09/24 16:09:18, Anton Muhin wrote:

+      }
     }
 
     registerSend(selector, setter);
     return useElement(node, setter);
   }
 
   void registerSend(Selector selector, Element target) {
     if (target === null || target.isInstanceMember()) {
       if (selector.isGetter()) {
         world.registerDynamicGetter(selector.name, selector);
@@ skipping 1302 matching lines @@
 
   Element localLookup(SourceString name) => library.find(name);
   Element lookup(SourceString name) => localLookup(name);
   Element lexicalLookup(SourceString name) => localLookup(name);
 
   Element add(Element newElement) {
     throw "Cannot add an element in the top scope";
   }
   String toString() => '$element';
 }