Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: lib/compiler/implementation/resolved_visitor.dart

Issue 10942028: Support class and typedef literals as expressions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add a comment. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 abstract class ResolvedVisitor<R> extends Visitor<R> { 5 abstract class ResolvedVisitor<R> extends Visitor<R> {
6 TreeElements elements; 6 TreeElements elements;
7 7
8 ResolvedVisitor(this.elements); 8 ResolvedVisitor(this.elements);
9 9
10 R visitSend(Send node) { 10 R visitSend(Send node) {
11 if (node.isSuperCall) { 11 if (node.isSuperCall) {
12 return visitSuperSend(node); 12 return visitSuperSend(node);
13 } else if (node.isOperator) { 13 } else if (node.isOperator) {
14 return visitOperatorSend(node); 14 return visitOperatorSend(node);
15 } else if (node.isPropertyAccess) { 15 } else if (node.isPropertyAccess) {
16 return visitGetterSend(node); 16 Element element = elements[node];
17 if (!Elements.isUnresolved(element)
18 && element.kind == ElementKind.CLASS) {
19 // A reference to a class literal.
20 return visitTypeReferenceSend(node);
21 } else {
22 return visitGetterSend(node);
23 }
24 // TODO(karlklose): implement reference to type variable.
17 } else if (Elements.isClosureSend(node, elements[node])) { 25 } else if (Elements.isClosureSend(node, elements[node])) {
18 return visitClosureSend(node); 26 return visitClosureSend(node);
19 } else { 27 } else {
20 Element element = elements[node]; 28 Element element = elements[node];
21 if (Elements.isUnresolved(element)) { 29 if (Elements.isUnresolved(element)) {
22 if (element == null) { 30 if (element == null) {
23 // Example: f() with 'f' unbound. 31 // Example: f() with 'f' unbound.
24 // This can only happen inside an instance method. 32 // This can only happen inside an instance method.
25 return visitDynamicSend(node); 33 return visitDynamicSend(node);
26 } else { 34 } else {
(...skipping 17 matching lines...) Expand all
44 } 52 }
45 } 53 }
46 54
47 abstract R visitSuperSend(Send node); 55 abstract R visitSuperSend(Send node);
48 abstract R visitOperatorSend(Send node); 56 abstract R visitOperatorSend(Send node);
49 abstract R visitGetterSend(Send node); 57 abstract R visitGetterSend(Send node);
50 abstract R visitClosureSend(Send node); 58 abstract R visitClosureSend(Send node);
51 abstract R visitDynamicSend(Send node); 59 abstract R visitDynamicSend(Send node);
52 abstract R visitForeignSend(Send node); 60 abstract R visitForeignSend(Send node);
53 abstract R visitStaticSend(Send node); 61 abstract R visitStaticSend(Send node);
62 abstract R visitTypeReferenceSend(Send node);
54 63
55 abstract void internalError(String reason, {Node node}); 64 abstract void internalError(String reason, {Node node});
56 65
57 R visitNode(Node node) { 66 R visitNode(Node node) {
58 internalError("Unhandled node", node: node); 67 internalError("Unhandled node", node: node);
59 } 68 }
60 } 69 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698