compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java - Issue 10942020: Issue 5215. Invocation identical(x,y) is compile-time constant

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java

Issue 10942020: Issue 5215. Invocation identical(x,y) is compile-time constant (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/resolver/Elements.java » ('j') | compiler/java/com/google/dart/compiler/resolver/Resolver.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java b/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java

index 4ed2b47e0d45bf3c47aee5250cd0a2de0c770694..48e501d75b30f7904609921f8542832618c66778 100644

--- a/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java

+++ b/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java

@@ -597,6 +597,12 @@ public class CompileTimeConstantAnalyzer {

@Override

public Void visitUnqualifiedInvocation(DartUnqualifiedInvocation x) {

+ Element element = x.getElement();

+ // "identical"

+ if (Elements.isFunctionIdentical(element)) {

+ x.visitChildren(this);

+ return null;

+ }

// No need to traverse, always disallowed.

expectedConstant(x);

return null;