Issue 5215. Invocation identical(x,y) is compile-time constant

compiler/java/com/google/dart/compiler/resolver/Resolver.java

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file

[Brian Wilkerson, 2012/09/19 14:06:58]

This file appears to have been accidentally included.

 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 package com.google.dart.compiler.resolver;
 
 import com.google.common.annotations.VisibleForTesting;
 import com.google.common.collect.Lists;
 import com.google.common.collect.Sets;
 import com.google.dart.compiler.DartCompilationPhase;
 import com.google.dart.compiler.DartCompilerContext;
 import com.google.dart.compiler.ErrorCode;
 import com.google.dart.compiler.ast.ASTNodes;
 import com.google.dart.compiler.ast.ASTVisitor;
 import com.google.dart.compiler.ast.DartArrayLiteral;
 import com.google.dart.compiler.ast.DartBinaryExpression;
 import com.google.dart.compiler.ast.DartBlock;
 import com.google.dart.compiler.ast.DartBooleanLiteral;
 import com.google.dart.compiler.ast.DartBreakStatement;
+import com.google.dart.compiler.ast.DartCase;
 import com.google.dart.compiler.ast.DartCatchBlock;
 import com.google.dart.compiler.ast.DartClass;
 import com.google.dart.compiler.ast.DartClassMember;
 import com.google.dart.compiler.ast.DartContinueStatement;
 import com.google.dart.compiler.ast.DartDirective;
 import com.google.dart.compiler.ast.DartDoWhileStatement;
 import com.google.dart.compiler.ast.DartDoubleLiteral;
+import com.google.dart.compiler.ast.DartExprStmt;
 import com.google.dart.compiler.ast.DartExpression;
 import com.google.dart.compiler.ast.DartField;
 import com.google.dart.compiler.ast.DartFieldDefinition;
 import com.google.dart.compiler.ast.DartForInStatement;
 import com.google.dart.compiler.ast.DartForStatement;
 import com.google.dart.compiler.ast.DartFunction;
 import com.google.dart.compiler.ast.DartFunctionExpression;
 import com.google.dart.compiler.ast.DartFunctionObjectInvocation;
 import com.google.dart.compiler.ast.DartFunctionTypeAlias;
 import com.google.dart.compiler.ast.DartGotoStatement;
@@ skipping 17 matching lines @@
 import com.google.dart.compiler.ast.DartRedirectConstructorInvocation;
 import com.google.dart.compiler.ast.DartReturnStatement;
 import com.google.dart.compiler.ast.DartStatement;
 import com.google.dart.compiler.ast.DartStringInterpolation;
 import com.google.dart.compiler.ast.DartStringLiteral;
 import com.google.dart.compiler.ast.DartSuperConstructorInvocation;
 import com.google.dart.compiler.ast.DartSuperExpression;
 import com.google.dart.compiler.ast.DartSwitchMember;
 import com.google.dart.compiler.ast.DartSwitchStatement;
 import com.google.dart.compiler.ast.DartThisExpression;
+import com.google.dart.compiler.ast.DartThrowExpression;
 import com.google.dart.compiler.ast.DartTryStatement;
 import com.google.dart.compiler.ast.DartTypeExpression;
 import com.google.dart.compiler.ast.DartTypeNode;
 import com.google.dart.compiler.ast.DartTypeParameter;
 import com.google.dart.compiler.ast.DartUnaryExpression;
 import com.google.dart.compiler.ast.DartUnit;
 import com.google.dart.compiler.ast.DartUnqualifiedInvocation;
 import com.google.dart.compiler.ast.DartVariable;
 import com.google.dart.compiler.ast.DartVariableStatement;
 import com.google.dart.compiler.ast.DartWhileStatement;
@@ skipping 924 matching lines @@
     }
 
 
     @Override
     public Element visitSwitchStatement(DartSwitchStatement x) {
       getContext().pushScope("<switch>");
       addLabelToStatement(x);
       // The scope of a label on the case statement is the case statement itself. These labels
       // need to be resolved before the continue <label>; statements can be resolved.
       for (DartSwitchMember member : x.getMembers()) {
-        recordSwitchMamberLabel(member);
+        recordSwitchMemberLabel(member);
       }
       x.visitChildren(this);
       getContext().popScope();
       return null;
     }
 
     @Override
+    public Element visitCase(DartCase node) {
+      super.visitCase(node);
+      List<DartStatement> statements = node.getStatements();
+      // the last statement should be: break, continue, return, throw
+      if (!statements.isEmpty()) {
+        DartStatement lastStatement = statements.get(statements.size() - 1);
+        if (!isValidLastSwitchCaseStatement(lastStatement)) {
+          onError(lastStatement, ResolverErrorCode.SWITCH_CASE_FALL_THROUGH);
+        }
+      }
+      // done
+      return null;
+    }
+
+    private boolean isValidLastSwitchCaseStatement(DartStatement statement) {
+      if (statement instanceof DartExprStmt) {
+        DartExprStmt exprStmt = (DartExprStmt) statement;
+        if (exprStmt.getExpression() instanceof DartThrowExpression) {
+          return true;
+        }
+      }
+      return statement instanceof DartBreakStatement || statement instanceof DartContinueStatement
+          || statement instanceof DartReturnStatement;
+    }
+
+    @Override
     public Element visitSwitchMember(DartSwitchMember x) {
       getContext().pushScope("<switch member>");
       x.visitChildren(this);
       getContext().popScope();
       return null;
     }
 
-    private void recordSwitchMamberLabel(DartSwitchMember x) {
+    private void recordSwitchMemberLabel(DartSwitchMember x) {
       List<DartLabel> labels = x.getLabels();
       for (DartLabel label : labels) {
         LabelElement labelElement =  Elements.switchMemberLabelElement(label, label.getName(),
             innermostFunction);
         recordElement(label.getLabel(), labelElement);
         recordElement(label, labelElement);
         if (getContext().getScope().hasLocalLabel(label.getName())) {
           onError(label, ResolverErrorCode.DUPLICATE_LABEL_IN_SWITCH_STATEMENT);
         }
         getContext().getScope().addLabel(labelElement);
@@ skipping 1302 matching lines @@
           ClassElement currentClass = (ClassElement) constructor.getEnclosingElement();
           if (nextClass == currentClass) {
             return (ConstructorNodeElement) nextConstructorElement;
           }
         }
       }
     }
     return null;
   }
 }