Cleanup: avoid foo ? true : false, part 2.

sandbox/win/src/policy_engine_processor.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sandbox/win/src/policy_engine_processor.h"
 
 namespace sandbox {
 
 void PolicyProcessor::SetInternalState(size_t index, EvalResult result) {
   state_.current_index_ = index;
   state_.current_result_ = result;
 }
 
 EvalResult PolicyProcessor::GetAction() const {
   return state_.current_result_;
 }
 
 // Decides if an opcode can be skipped (not evaluated) or not. The function
 // takes as inputs the opcode and the current evaluation context and returns
 // true if the opcode should be skipped or not and also can set keep_skipping
 // to false to signal that the current instruction should be skipped but not
 // the next after the current one.
-bool SkipOpcode(PolicyOpcode& opcode, MatchContext* context,
+bool SkipOpcode(const PolicyOpcode& opcode, MatchContext* context,
                 bool* keep_skipping) {
   if (opcode.IsAction()) {
     uint32 options = context->options;
     context->Clear();
     *keep_skipping = false;
-    return (kPolUseOREval == options)? false : true;
+    return (kPolUseOREval != options);
   }
   *keep_skipping = true;
   return true;
 }
 
 PolicyResult PolicyProcessor::Evaluate(uint32 options,
                                        ParameterSet* parameters,
                                        size_t param_count) {
   if (NULL == policy_) {
     return NO_POLICY_MATCH;
@@ skipping 58 matching lines @@
   if (evaluation) {
     // Reaching the end of the policy with a positive evaluation is probably
     // an error: we did not find a final action opcode?
     return POLICY_ERROR;
   }
   return NO_POLICY_MATCH;
 }
 
 
 }  // namespace sandbox