content/public/browser/web_contents.h - Issue 1094153002: Move ClosePage() from RenderViewHost to WebContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/web_contents.h

Issue 1094153002: Move ClosePage() from RenderViewHost to WebContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes based on reviews. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_view_host_impl.h ('K') | « content/public/browser/render_view_host.h ('k') | extensions/browser/process_manager.cc » ('j') | extensions/browser/process_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/web_contents.h

diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h

index 43804129322c4ed56ffc7b451c6ae1e5b84bfc2d..8ccd0b487d2a7ddb5b91582fff10daf5363c1ab2 100644

--- a/content/public/browser/web_contents.h

+++ b/content/public/browser/web_contents.h

@@ -220,6 +220,10 @@ class WebContents : public PageNavigator,

// time and can be nullptr (during setup and teardown).

virtual RenderWidgetHostView* GetRenderWidgetHostView() const = 0;

+ // Causes the current page to be closed, including running its onunload event

+ // handler. A ClosePage_ACK message is sent when it is finished.

Charlie Reis 2015/04/29 17:31:18 We probably don't need to mention the ACK here, si

nasko 2015/04/29 21:15:33 Done.

+ virtual void ClosePage() = 0;

// Returns the currently active fullscreen widget. If there is none, returns

// nullptr.

virtual RenderWidgetHostView* GetFullscreenRenderWidgetHostView() const = 0;