Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: extensions/browser/process_manager.cc

Issue 1094153002: Move ClosePage() from RenderViewHost to WebContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix chromecast android compile failure. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/web_contents.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/process_manager.cc
diff --git a/extensions/browser/process_manager.cc b/extensions/browser/process_manager.cc
index 47f7b191e004da8dccf2a6179c9a17a73471752f..d1908d2cd79155947f6e0cf7cffabe739a67f223 100644
--- a/extensions/browser/process_manager.cc
+++ b/extensions/browser/process_manager.cc
@@ -805,8 +805,8 @@ void ProcessManager::CloseLazyBackgroundPageNow(const std::string& extension_id,
}
}
for (content::RenderFrameHost* frame : frames_to_close) {
- frame->GetRenderViewHost()->ClosePage();
- // RenderViewHost::ClosePage() may result in calling
+ content::WebContents::FromRenderFrameHost(frame)->ClosePage();
+ // WebContents::ClosePage() may result in calling
// UnregisterRenderViewHost() asynchronously and may cause race conditions
// when the background page is reloaded.
// To avoid this, unregister the view now.
« no previous file with comments | « content/public/browser/web_contents.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698