content/browser/renderer_host/render_view_host_impl.h - Issue 1094153002: Move ClosePage() from RenderViewHost to WebContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 1094153002: Move ClosePage() from RenderViewHost to WebContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix chromecast android compile failure. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/render_frame_devtools_agent_host.cc ('k') | content/browser/renderer_host/render_view_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_impl.h

diff --git a/content/browser/renderer_host/render_view_host_impl.h b/content/browser/renderer_host/render_view_host_impl.h

index 2b031ff77c3a8f64bd8a3b2a47118199164792ac..f5f3dec861ff47cbce07a926e1ceef524ef31384 100644

--- a/content/browser/renderer_host/render_view_host_impl.h

+++ b/content/browser/renderer_host/render_view_host_impl.h

@@ -123,7 +123,6 @@ class CONTENT_EXPORT RenderViewHostImpl

void AllowBindings(int binding_flags) override;

void ClearFocusedElement() override;

bool IsFocusedElementEditable() override;

- void ClosePage() override;

void CopyImageAt(int x, int y) override;

void SaveImageAt(int x, int y) override;

void DirectoryEnumerationFinished(

@@ -227,6 +226,10 @@ class CONTENT_EXPORT RenderViewHostImpl

// longer on the stack when we attempt to swap it out.

void SuppressDialogsUntilSwapOut();

+ // Tells the renderer process to run the page's unload handler.

+ // A ClosePage_ACK ack is sent back when the handler execution completes.

+ void ClosePage();

// Close the page ignoring whether it has unload events registers.

// This is called after the beforeunload and unload events have fired

// and the user has agreed to continue with closing the page.