chromecast/browser/service/cast_service_simple.cc - Issue 1094153002: Move ClosePage() from RenderViewHost to WebContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/service/cast_service_simple.cc

Issue 1094153002: Move ClosePage() from RenderViewHost to WebContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix chromecast android compile failure. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromecast/browser/android/cast_window_android.cc ('k') | content/browser/devtools/render_frame_devtools_agent_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/service/cast_service_simple.cc

diff --git a/chromecast/browser/service/cast_service_simple.cc b/chromecast/browser/service/cast_service_simple.cc

index 9c7ca6d3fc6b8182ced4d8826b70b78cb0e804d1..6b72051af29451c7213304e9c01ea9fe82be4594 100644

--- a/chromecast/browser/service/cast_service_simple.cc

+++ b/chromecast/browser/service/cast_service_simple.cc

@@ -73,7 +73,7 @@ void CastServiceSimple::StartInternal() {

}

void CastServiceSimple::StopInternal() {

- web_contents_->GetRenderViewHost()->ClosePage();

+ web_contents_->ClosePage();

web_contents_.reset();

window_.reset();

}

« no previous file with comments | « chromecast/browser/android/cast_window_android.cc ('k') | content/browser/devtools/render_frame_devtools_agent_host.cc » ('j') | no next file with comments »