chrome/browser/devtools/devtools_window.cc - Issue 1094153002: Move ClosePage() from RenderViewHost to WebContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 1094153002: Move ClosePage() from RenderViewHost to WebContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix chromecast android compile failure. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/devtools/devtools_window.cc

diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc

index d0694121f1eb1799f61d4a852df2a6f34621e6b4..f9b25a4ba76014ca0e7e4dc351c59a6f4abdf3f8 100644

--- a/chrome/browser/devtools/devtools_window.cc

+++ b/chrome/browser/devtools/devtools_window.cc

@@ -1056,7 +1056,7 @@ void DevToolsWindow::SetWhitelistedShortcuts(

void DevToolsWindow::InspectedContentsClosing() {

intercepted_page_beforeunload_ = false;

life_stage_ = kClosing;

- main_web_contents_->GetRenderViewHost()->ClosePage();

+ main_web_contents_->ClosePage();

}

InfoBarService* DevToolsWindow::GetInfoBarService() {

« no previous file with comments | « chrome/browser/devtools/devtools_ui_bindings.cc ('k') | chrome/browser/ui/fast_unload_controller.cc » ('j') | no next file with comments »