Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: extensions/browser/process_manager.cc

Issue 1094153002: Move ClosePage() from RenderViewHost to WebContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/process_manager.cc
diff --git a/extensions/browser/process_manager.cc b/extensions/browser/process_manager.cc
index 47f7b191e004da8dccf2a6179c9a17a73471752f..1ecbd6e86d427470ddecd5657ff7b516cee611aa 100644
--- a/extensions/browser/process_manager.cc
+++ b/extensions/browser/process_manager.cc
@@ -805,7 +805,7 @@ void ProcessManager::CloseLazyBackgroundPageNow(const std::string& extension_id,
}
}
for (content::RenderFrameHost* frame : frames_to_close) {
- frame->GetRenderViewHost()->ClosePage();
+ content::WebContents::FromRenderFrameHost(frame)->ClosePage();
// RenderViewHost::ClosePage() may result in calling
Charlie Reis 2015/04/21 17:28:09 nit: Update comment.
nasko 2015/04/29 17:09:27 Done.
// UnregisterRenderViewHost() asynchronously and may cause race conditions
// when the background page is reloaded.
« content/public/browser/web_contents.h ('K') | « content/public/browser/web_contents.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698