Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Side by Side Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 1094153002: Move ClosePage() from RenderViewHost to WebContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes based on reviews. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 bool swapped_out, 116 bool swapped_out,
117 bool hidden, 117 bool hidden,
118 bool has_initialized_audio_host); 118 bool has_initialized_audio_host);
119 ~RenderViewHostImpl() override; 119 ~RenderViewHostImpl() override;
120 120
121 // RenderViewHost implementation. 121 // RenderViewHost implementation.
122 RenderFrameHost* GetMainFrame() override; 122 RenderFrameHost* GetMainFrame() override;
123 void AllowBindings(int binding_flags) override; 123 void AllowBindings(int binding_flags) override;
124 void ClearFocusedElement() override; 124 void ClearFocusedElement() override;
125 bool IsFocusedElementEditable() override; 125 bool IsFocusedElementEditable() override;
126 void ClosePage() override;
127 void CopyImageAt(int x, int y) override; 126 void CopyImageAt(int x, int y) override;
128 void SaveImageAt(int x, int y) override; 127 void SaveImageAt(int x, int y) override;
129 void DirectoryEnumerationFinished( 128 void DirectoryEnumerationFinished(
130 int request_id, 129 int request_id,
131 const std::vector<base::FilePath>& files) override; 130 const std::vector<base::FilePath>& files) override;
132 void DisableScrollbarsForThreshold(const gfx::Size& size) override; 131 void DisableScrollbarsForThreshold(const gfx::Size& size) override;
133 void DragSourceEndedAt(int client_x, 132 void DragSourceEndedAt(int client_x,
134 int client_y, 133 int client_y,
135 int screen_x, 134 int screen_x,
136 int screen_y, 135 int screen_y,
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 219
221 // TODO(creis): Remove as part of http://crbug.com/418265. 220 // TODO(creis): Remove as part of http://crbug.com/418265.
222 bool is_waiting_for_close_ack() const { return is_waiting_for_close_ack_; } 221 bool is_waiting_for_close_ack() const { return is_waiting_for_close_ack_; }
223 222
224 // Tells the renderer that this RenderView will soon be swapped out, and thus 223 // Tells the renderer that this RenderView will soon be swapped out, and thus
225 // not to create any new modal dialogs until it happens. This must be done 224 // not to create any new modal dialogs until it happens. This must be done
226 // separately so that the PageGroupLoadDeferrers of any current dialogs are no 225 // separately so that the PageGroupLoadDeferrers of any current dialogs are no
227 // longer on the stack when we attempt to swap it out. 226 // longer on the stack when we attempt to swap it out.
228 void SuppressDialogsUntilSwapOut(); 227 void SuppressDialogsUntilSwapOut();
229 228
229 // Tells the renderer process to run the page's unload handler. An ack is sent
Charlie Reis 2015/04/29 17:31:18 An ack -> A ClosePage_ACK
nasko 2015/04/29 21:15:33 Done.
230 // back when the handler execution completes.
231 void ClosePage();
232
230 // Close the page ignoring whether it has unload events registers. 233 // Close the page ignoring whether it has unload events registers.
231 // This is called after the beforeunload and unload events have fired 234 // This is called after the beforeunload and unload events have fired
232 // and the user has agreed to continue with closing the page. 235 // and the user has agreed to continue with closing the page.
233 void ClosePageIgnoringUnloadEvents(); 236 void ClosePageIgnoringUnloadEvents();
234 237
235 // Tells the renderer view to focus the first (last if reverse is true) node. 238 // Tells the renderer view to focus the first (last if reverse is true) node.
236 void SetInitialFocus(bool reverse); 239 void SetInitialFocus(bool reverse);
237 240
238 // Get html data by serializing all frames of current page with lists 241 // Get html data by serializing all frames of current page with lists
239 // which contain all resource links that have local copy. 242 // which contain all resource links that have local copy.
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
455 DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl); 458 DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl);
456 }; 459 };
457 460
458 #if defined(COMPILER_MSVC) 461 #if defined(COMPILER_MSVC)
459 #pragma warning(pop) 462 #pragma warning(pop)
460 #endif 463 #endif
461 464
462 } // namespace content 465 } // namespace content
463 466
464 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 467 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698