Move ClosePage() from RenderViewHost to WebContents.

chrome/browser/ui/fast_unload_controller.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/fast_unload_controller.h"
 
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/devtools/devtools_window.h"
@@ skipping 397 matching lines @@
   // Process all the unload handlers. (The beforeunload handlers have finished.)
   if (!tabs_needing_unload_.empty()) {
     browser_->OnWindowClosing();
 
     // Run unload handlers detached since no more interaction is possible.
     WebContentsSet::iterator it = tabs_needing_unload_.begin();
     while (it != tabs_needing_unload_.end()) {
       WebContentsSet::iterator current = it++;
       content::WebContents* contents = *current;
       tabs_needing_unload_.erase(current);
       // Null check render_view_host here as this gets called on a PostTask

[Charlie Reis, 2015/04/21 17:28:08]

I'm having trouble imagining how the WebContents could have a null RVH without
being deleted.  That said, we do have RVH null checks scattered throughout
WebContents.  Can you remind me why they're necessary?  (This might be a good
thing for Lucas to mention in his doc, or else something we can clean up.)

[nasko, 2015/04/29 17:09:27]

I don't know what the reason is. I think changing this belongs to another CL and
it is probably something we should try to clean up.

       // and the tab's render_view_host may have been nulled out.
       if (contents->GetRenderViewHost()) {
         CoreTabHelper* core_tab_helper =
             CoreTabHelper::FromWebContents(contents);
         core_tab_helper->OnUnloadStarted();
         DetachWebContents(contents);
-        contents->GetRenderViewHost()->ClosePage();
+        contents->ClosePage();
       }
     }
 
     // Get the browser hidden.
     if (browser_->tab_strip_model()->empty()) {
       browser_->TabStripEmpty();
     } else {
       browser_->tab_strip_model()->CloseAllTabs();  // tabs not needing unload
     }
     return;
@@ skipping 37 matching lines @@
 }
 
 void FastUnloadController::PostTaskForProcessPendingTabs() {
   base::MessageLoop::current()->PostTask(
       FROM_HERE,
       base::Bind(&FastUnloadController::ProcessPendingTabs,
                  weak_factory_.GetWeakPtr()));
 }
 
 }  // namespace chrome