Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Side by Side Diff: Source/core/paint/DeprecatedPaintLayer.cpp

Issue 1094133004: Image maps should work for images with alt content (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/layout/LayoutView.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 2042 matching lines...) Expand 10 before | Expand all | Expand 10 after
2053 2053
2054 if (layoutObject()->isLayoutFlowThread()) { 2054 if (layoutObject()->isLayoutFlowThread()) {
2055 // For a flow thread it's safe to just say that we didn't hit anythi ng. That means that 2055 // For a flow thread it's safe to just say that we didn't hit anythi ng. That means that
2056 // we'll continue as normally, and eventually hit a column set sibli ng instead. Column 2056 // we'll continue as normally, and eventually hit a column set sibli ng instead. Column
2057 // sets are also anonymous, but, unlike flow threads, they don't est ablish layers, so 2057 // sets are also anonymous, but, unlike flow threads, they don't est ablish layers, so
2058 // we'll fall back and hit the multicol container parent (which shou ld have a DOM node). 2058 // we'll fall back and hit the multicol container parent (which shou ld have a DOM node).
2059 return false; 2059 return false;
2060 } 2060 }
2061 2061
2062 Node* e = enclosingElement(); 2062 Node* e = enclosingElement();
2063 if (!result.innerNode()) 2063 // FIXME: should be a call to result.setNodeAndPosition. What we would r eally want to do here is to
2064 result.setInnerNode(e);
2065
2066 // FIXME: missing call to result.setLocalPoint(). What we would really w ant to do here is to
2067 // return and look for the nearest non-anonymous ancestor, and ignore au nts and uncles on 2064 // return and look for the nearest non-anonymous ancestor, and ignore au nts and uncles on
2068 // our way. It's bad to look for it manually like we do here, and give u p on setting a local 2065 // our way. It's bad to look for it manually like we do here, and give u p on setting a local
2069 // point in the result, because that has bad implications for text selec tion and 2066 // point in the result, because that has bad implications for text selec tion and
2070 // caretRangeFromPoint(). See crbug.com/461791 2067 // caretRangeFromPoint(). See crbug.com/461791
2068 if (!result.innerNode())
2069 result.setInnerNode(e);
2070
2071 } 2071 }
2072 return true; 2072 return true;
2073 } 2073 }
2074 2074
2075 DeprecatedPaintLayer* DeprecatedPaintLayer::hitTestChildren(ChildrenIteration ch ildrentoVisit, DeprecatedPaintLayer* rootLayer, 2075 DeprecatedPaintLayer* DeprecatedPaintLayer::hitTestChildren(ChildrenIteration ch ildrentoVisit, DeprecatedPaintLayer* rootLayer,
2076 HitTestResult& result, 2076 HitTestResult& result,
2077 const LayoutRect& hitTestRect, const HitTestLocation& hitTestLocation, 2077 const LayoutRect& hitTestRect, const HitTestLocation& hitTestLocation,
2078 const HitTestingTransformState* transformState, 2078 const HitTestingTransformState* transformState,
2079 double* zOffsetForDescendants, double* zOffset, 2079 double* zOffsetForDescendants, double* zOffset,
2080 const HitTestingTransformState* unflattenedTransformState, 2080 const HitTestingTransformState* unflattenedTransformState,
(...skipping 884 matching lines...) Expand 10 before | Expand all | Expand 10 after
2965 } 2965 }
2966 } 2966 }
2967 2967
2968 void showLayerTree(const blink::LayoutObject* layoutObject) 2968 void showLayerTree(const blink::LayoutObject* layoutObject)
2969 { 2969 {
2970 if (!layoutObject) 2970 if (!layoutObject)
2971 return; 2971 return;
2972 showLayerTree(layoutObject->enclosingLayer()); 2972 showLayerTree(layoutObject->enclosingLayer());
2973 } 2973 }
2974 #endif 2974 #endif
OLDNEW
« no previous file with comments | « Source/core/layout/LayoutView.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698