Image maps should work for images with alt content

Source/core/layout/HitTestResult.cpp

 /*
  * Copyright (C) 2006, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Nokia Corporation and/or its subsidiary(-ies)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 135 matching lines @@
 void HitTestResult::setToShadowHostIfInUserAgentShadowRoot()
 {
     if (Node* node = innerNode()) {
         if (ShadowRoot* containingShadowRoot = node->containingShadowRoot()) {
             if (containingShadowRoot->type() == ShadowRoot::UserAgentShadowRoot)
                 setInnerNode(node->shadowHost());
         }
     }
 }
 
+HTMLAreaElement* HitTestResult::imageAreaForImage()

[pdr., 2015/04/26 02:59:15]

Lets make this function const since it doesn't modify m_innerNode itself.
HTMLAreaElement* HitTestResult::imageAreaForImage() const

+{
+    HTMLImageElement* imageElement = nullptr;

[pdr., 2015/04/26 02:59:15]

Even though we check it all over, I don't think m_innerNode can be null here.
Can you assert that?
ASSERT(m_innerNode);

+    if (isHTMLImageElement(innerNode()))
+        imageElement = toHTMLImageElement(innerNode());
+    else if (isHTMLImageElement(innerNode()->shadowHost()))

[pdr., 2015/04/26 02:59:15]

I think we need to limit this to user agent shadow hosts. For performance we may
want to check isInShadowTree too.

WDYT of the following?
if (isHTMLImageElement(m_innerNode)) {
    imageElement = toHTMLImageElement(innerNode());
} else if (m_innerNode->isInShadowTree()) {
    ShadowRoot* containingShadowRoot = m_innerNode->containingShadowRoot();
    if (containingShadowRoot->type() == ShadowRoot::UserAgentShadowRoot) {
        if (isHTMLImageElement(m_innerNode->shadowHost()))
            imageElement = toHTMLImageElement(m_innerNode->shadowHost());
    }
}

+        imageElement = toHTMLImageElement(innerNode()->shadowHost());
+
+    if (!imageElement)
+        return nullptr;
+
+    LayoutBox* box = toLayoutBox(layoutObject());

[pdr., 2015/04/26 02:59:15]

Nit: this can be moved inside the map conditional below.

+    LayoutRect contentBox = box->contentBoxRect();
+    float scaleFactor = 1 / box->style()->effectiveZoom();
+    LayoutPoint location = localPoint();
+    location.scale(scaleFactor, scaleFactor);
+
+    if (HTMLMapElement* map = imageElement->treeScope().getImageMap(imageElement->fastGetAttribute(usemapAttr)))
+        return map->areaForPoint(location, contentBox.size());
+    return nullptr;
+}
+
 void HitTestResult::setInnerNode(Node* n)
 {
     m_innerPossiblyPseudoNode = n;
     if (n && n->isPseudoElement())
         n = toPseudoElement(n)->findAssociatedNode();
     m_innerNode = n;
+    if (HTMLAreaElement* area = imageAreaForImage())
+        m_innerNode = area;
 }
 
 void HitTestResult::setURLElement(Element* n)
 {
     m_innerURLElement = n;
 }
 
 void HitTestResult::setScrollbar(Scrollbar* s)
 {
     m_scrollbar = s;
@@ skipping 306 matching lines @@
     else if (isHTMLMapElement(m_innerNode))
         imageMapImageElement = toHTMLMapElement(m_innerNode)->imageElement();
 
     if (!imageMapImageElement)
         return m_innerNode.get();
 
     return imageMapImageElement;
 }
 
 } // namespace blink