remoting/webapp/build-webapp.py - Issue 1094133003: Added (incomplete) implementation of HostListApi using GCD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/build-webapp.py

Issue 1094133003: Added (incomplete) implementation of HostListApi using GCD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gcd-client-fix

Patch Set: Removed extranous TODO Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/webapp/build-webapp.py

diff --git a/remoting/webapp/build-webapp.py b/remoting/webapp/build-webapp.py

index 979b593aab2b19df90be59b7a10e408fe08cfaa6..c30d3496cbbd2fe55dc5fcceaa6d59096c5e7577 100755

--- a/remoting/webapp/build-webapp.py

+++ b/remoting/webapp/build-webapp.py

@@ -350,6 +350,8 @@ def buildWebApp(buildtype, version, destination, zip_path,

# For overriding the client ID/secret via env vars, see google_api_keys.py.

apiClientId = google_api_keys.GetClientID('REMOTING')

apiClientSecret = google_api_keys.GetClientSecret('REMOTING')

+ apiClientSecret = google_api_keys.GetClientSecret('REMOTING')

Jamie 2015/04/24 18:18:53 Duplicate line?

John Williams 2015/04/24 21:10:17 Fixed.

+ apiKey = google_api_keys.GetAPIKeyRemoting()

if is_app_remoting_webapp and buildtype != 'Dev':

if not app_client_id:

@@ -361,6 +363,7 @@ def buildWebApp(buildtype, version, destination, zip_path,

replaceString(destination, 'API_CLIENT_ID', apiClientId)

replaceString(destination, 'API_CLIENT_SECRET', apiClientSecret)

+ replaceString(destination, 'API_KEY', apiKey)

# Write the application capabilities.

appCapabilities = ','.join(

« no previous file with comments | « remoting/remoting_webapp_files.gypi ('k') | remoting/webapp/crd/js/host_controller.js » ('j') | remoting/webapp/crd/js/host_list_api.js » ('J')