Added (incomplete) implementation of HostListApi using GCD.

Added (incomplete) implementation of HostListApi using GCD.

The new implementation is activated when USE_GCD=1 at build time.

BUG=471928
Committed: https://crrev.com/0ffae3270ed1461a9a90febbe4f555c21181c188
Cr-Commit-Position: refs/heads/master@{#327111}

[John Williams, 2015-04-22 17:16:11]

jrw@chromium.org changed reviewers:
+ jamiewalch@google.com

[Jamie, 2015-04-22 23:46:01]

jamiewalch@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Jamie, 2015-04-22 23:46:02]

Is this CL based off something local to your checkout? It contains a lot of code
not inside diffs that I don't have in my checkout (but maybe I just need to
update).

https://codereview.chromium.org/1094133003/diff/1/remoting/webapp/crd/js/host...
File remoting/webapp/crd/js/host_list.js (right):

https://codereview.chromium.org/1094133003/diff/1/remoting/webapp/crd/js/host...
remoting/webapp/crd/js/host_list.js:331: catch(this.onError_);
Indentation is a bit confusing here. I suggest assigning the result of
getInstance() to a local variable so that the previous indentation pattern will
still fit within 80 columns.

https://codereview.chromium.org/1094133003/diff/1/remoting/webapp/crd/js/host...
File remoting/webapp/crd/js/host_list_api.js (right):

https://codereview.chromium.org/1094133003/diff/1/remoting/webapp/crd/js/host...
remoting/webapp/crd/js/host_list_api.js:28:
remoting.HostListApi.prototype.register;
This method is not implemented by remoting.HostListApiImpl, and should be
declared as an empty function like all the other methods. It also needs better
documentation.

https://codereview.chromium.org/1094133003/diff/1/remoting/webapp/crd/js/host...
File remoting/webapp/crd/js/host_list_api_gcd_impl.js (right):

https://codereview.chromium.org/1094133003/diff/1/remoting/webapp/crd/js/host...
remoting/webapp/crd/js/host_list_api_gcd_impl.js:24: apiKey:
'AIzaSyBs-PPti9HWLCqGtU_QyIRD4kSfb-0wnbU'
API keys should be checked in to google_apis/internal

https://codereview.chromium.org/1094133003/diff/1/remoting/webapp/crd/js/host...
remoting/webapp/crd/js/host_list_api_gcd_impl.js:31: // TODO(jrw)
Please be more specific about what remains to be done.

[John Williams, 2015-04-23 23:55:35]

On 2015/04/22 23:46:02, Jamie wrote:
> Is this CL based off something local to your checkout? It contains a lot of
code
> not inside diffs that I don't have in my checkout (but maybe I just need to
> update).

It goes along with some other CLs I had Kelvin review.  Those are all landed
now, so hopefully this one will make more sense.  I was trying to spread out the
reviewing load but I guess that was the opposite of what I should have done.

[John Williams, 2015-04-23 23:55:42]

https://codereview.chromium.org/1094133003/diff/1/remoting/webapp/crd/js/host...
File remoting/webapp/crd/js/host_list.js (right):

https://codereview.chromium.org/1094133003/diff/1/remoting/webapp/crd/js/host...
remoting/webapp/crd/js/host_list.js:331: catch(this.onError_);
On 2015/04/22 23:46:01, Jamie wrote:
> Indentation is a bit confusing here. I suggest assigning the result of
> getInstance() to a local variable so that the previous indentation pattern
will
> still fit within 80 columns.

Done.

https://codereview.chromium.org/1094133003/diff/1/remoting/webapp/crd/js/host...
File remoting/webapp/crd/js/host_list_api.js (right):

https://codereview.chromium.org/1094133003/diff/1/remoting/webapp/crd/js/host...
remoting/webapp/crd/js/host_list_api.js:28:
remoting.HostListApi.prototype.register;
On 2015/04/22 23:46:01, Jamie wrote:
> This method is not implemented by remoting.HostListApiImpl, and should be
> declared as an empty function like all the other methods. It also needs better
> documentation.

It's implemented by remoting.HostListApiImpl since issue #1098563002.

I added comments and an empty function.

https://codereview.chromium.org/1094133003/diff/1/remoting/webapp/crd/js/host...
File remoting/webapp/crd/js/host_list_api_gcd_impl.js (right):

https://codereview.chromium.org/1094133003/diff/1/remoting/webapp/crd/js/host...
remoting/webapp/crd/js/host_list_api_gcd_impl.js:24: apiKey:
'AIzaSyBs-PPti9HWLCqGtU_QyIRD4kSfb-0wnbU'
On 2015/04/22 23:46:01, Jamie wrote:
> API keys should be checked in to google_apis/internal

Done.

https://codereview.chromium.org/1094133003/diff/1/remoting/webapp/crd/js/host...
remoting/webapp/crd/js/host_list_api_gcd_impl.js:31: // TODO(jrw)
On 2015/04/22 23:46:01, Jamie wrote:
> Please be more specific about what remains to be done.

That TODO is obsolete.  Removed.

[Jamie, 2015-04-24 18:18:54]

lgtm

https://codereview.chromium.org/1094133003/diff/60001/remoting/webapp/build-w...
File remoting/webapp/build-webapp.py (right):

https://codereview.chromium.org/1094133003/diff/60001/remoting/webapp/build-w...
remoting/webapp/build-webapp.py:353: apiClientSecret =
google_api_keys.GetClientSecret('REMOTING')
Duplicate line?

https://codereview.chromium.org/1094133003/diff/60001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/host_list_api.js (right):

https://codereview.chromium.org/1094133003/diff/60001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/host_list_api.js:25: * @param {string} newHostId The ID
of the new host the register.
s/ the register//?

[John Williams, 2015-04-24 21:10:17]

https://codereview.chromium.org/1094133003/diff/60001/remoting/webapp/build-w...
File remoting/webapp/build-webapp.py (right):

https://codereview.chromium.org/1094133003/diff/60001/remoting/webapp/build-w...
remoting/webapp/build-webapp.py:353: apiClientSecret =
google_api_keys.GetClientSecret('REMOTING')
On 2015/04/24 18:18:53, Jamie wrote:
> Duplicate line?

Fixed.

https://codereview.chromium.org/1094133003/diff/60001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/host_list_api.js (right):

https://codereview.chromium.org/1094133003/diff/60001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/host_list_api.js:25: * @param {string} newHostId The ID
of the new host the register.
On 2015/04/24 18:18:54, Jamie wrote:
> s/ the register//?

Done.

[John Williams, 2015-04-24 21:10:20]

The CQ bit was checked by jrw@chromium.org

[John Williams, 2015-04-24 21:10:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/1094133003/#ps80001
(title: "for submit")

[commit-bot: I haz the power, 2015-04-24 21:11:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1094133003/80001

[commit-bot: I haz the power, 2015-04-24 21:20:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-24 21:20:46]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[John Williams, 2015-04-24 22:15:18]

jrw@chromium.org changed reviewers:
+ rogerta@chromium.org

[John Williams, 2015-04-24 22:15:18]

Need OWNERS approval for google_apis/google_api_keys.py

[Roger Tawa OOO till Jul 10th, 2015-04-27 15:20:07]

lgtm google_api_keys.py

[John Williams, 2015-04-27 19:14:10]

The CQ bit was checked by jrw@chromium.org

[commit-bot: I haz the power, 2015-04-27 19:14:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1094133003/80001

[commit-bot: I haz the power, 2015-04-27 20:08:40]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-27 20:10:35]

Patchset 5 (id:??) landed as
https://crrev.com/0ffae3270ed1461a9a90febbe4f555c21181c188
Cr-Commit-Position: refs/heads/master@{#327111}