Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Unified Diff: chrome/browser/extensions/global_shortcut_listener_mac.cc

Issue 109413003: Refactor GlobalShortcutListener. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clearer logic. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/global_shortcut_listener_mac.cc
diff --git a/chrome/browser/extensions/global_shortcut_listener_mac.cc b/chrome/browser/extensions/global_shortcut_listener_mac.cc
index 3604c853dfce70691a2413173a2ac36aa4486394..831da4c67d3c497a626e4bef764c7617a1edd788 100644
--- a/chrome/browser/extensions/global_shortcut_listener_mac.cc
+++ b/chrome/browser/extensions/global_shortcut_listener_mac.cc
@@ -48,28 +48,22 @@ void GlobalShortcutListenerMac::StopListening() {
is_listening_ = false;
}
-void GlobalShortcutListenerMac::RegisterAccelerator(
- const ui::Accelerator& accelerator,
- GlobalShortcutListener::Observer* observer) {
+bool GlobalShortcutListenerMac::RegisterAcceleratorImpl(
+ const ui::Accelerator& accelerator) {
NOTIMPLEMENTED();
// To implement:
// 1) Convert modifiers to platform specific modifiers.
// 2) Register for the hotkey.
- // 3) If not successful, log why.
- // 4) Else, call base class RegisterAccelerator.
+ // 3) If not successful, log why and return false.
+ // 4) Else, return true.
- GlobalShortcutListener::RegisterAccelerator(accelerator, observer);
+ return false;
}
-void GlobalShortcutListenerMac::UnregisterAccelerator(
- const ui::Accelerator& accelerator,
- GlobalShortcutListener::Observer* observer) {
+void GlobalShortcutListenerMac::UnregisterAcceleratorImpl(
+ const ui::Accelerator& accelerator) {
NOTIMPLEMENTED();
- // To implement:
- // 1) Unregister for the hotkey.
- // 2) Call base class UnregisterAccelerator.
-
- GlobalShortcutListener::UnregisterAccelerator(accelerator, observer);
+ // To implement: Unregister for the hotkey.
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698