Allow out-of-process iframes to render to compositing surfaces.

content/browser/frame_host/render_widget_host_view_child_frame.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_
 #define CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_
 
 #include "base/memory/scoped_ptr.h"
+#include "cc/resources/returned_resource.h"
+#include "cc/surfaces/surface_factory_client.h"
+#include "cc/surfaces/surface_id_allocator.h"
+#include "content/browser/compositor/image_transport_factory.h"
 #include "content/browser/renderer_host/render_widget_host_view_base.h"
 #include "content/common/content_export.h"
 #include "content/public/browser/readback_types.h"
+#include "ui/compositor/compositor.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/native_widget_types.h"
 
+namespace cc {
+class SurfaceFactory;
+enum class SurfaceDrawStatus;
+}
+
 namespace content {
 class CrossProcessFrameConnector;
 class RenderWidgetHost;
 class RenderWidgetHostImpl;
+class RenderWidgetHostViewChildFrameTest;
 
 // RenderWidgetHostViewChildFrame implements the view for a RenderWidgetHost
 // associated with content being rendered in a separate process from
 // content that is embedding it. This is not a platform-specific class; rather,
 // the embedding renderer process implements the platform containing the
 // widget, and the top-level frame's RenderWidgetHostView will ultimately
 // manage all native widget interaction.
 //
 // See comments in render_widget_host_view.h about this class and its members.
 class CONTENT_EXPORT RenderWidgetHostViewChildFrame
-    : public RenderWidgetHostViewBase {
+    : public RenderWidgetHostViewBase,
+      public cc::SurfaceFactoryClient,
+      public base::SupportsWeakPtr<RenderWidgetHostViewChildFrame> {

[dcheng, 2015/05/28 22:24:55]

Prefer to embed a WeakPtrFactory rather than inheriting from SupportsWeakPtr<>.
Doing the latter allows other people to grab a weak pointer to your class, which
we don't need (or want) in this case.

[kenrb, 2015/05/29 19:29:36]

Done.

  public:
   explicit RenderWidgetHostViewChildFrame(RenderWidgetHost* widget);
   ~RenderWidgetHostViewChildFrame() override;
 
   void set_cross_process_frame_connector(
       CrossProcessFrameConnector* frame_connector) {
     frame_connector_ = frame_connector;
   }
 
   // RenderWidgetHostView implementation.
@@ skipping 86 matching lines @@
 #endif  // defined(OS_ANDROID)
 
 #if defined(OS_WIN)
   void SetParentNativeViewAccessible(
       gfx::NativeViewAccessible accessible_parent) override;
   gfx::NativeViewId GetParentForWindowlessPlugin() const override;
 #endif
   BrowserAccessibilityManager* CreateBrowserAccessibilityManager(
       BrowserAccessibilityDelegate* delegate) override;
 
+  // cc::SurfaceFactoryClient implementation.
+  void ReturnResources(const cc::ReturnedResourceArray& resources) override;
+
  protected:
   friend class RenderWidgetHostView;
+  friend class RenderWidgetHostViewChildFrameTest;
+
+  void SurfaceDrawn(uint32 output_surface_id, cc::SurfaceDrawStatus drawn);
 
   // The last scroll offset of the view.
   gfx::Vector2dF last_scroll_offset_;
 
   // Members will become private when RenderWidgetHostViewGuest is removed.
   // The model object.
   RenderWidgetHostImpl* host_;
 
+  // Flag determining whether we render into a compositing surface.

[nasko, 2015/05/28 20:42:36]

nit: Is it Surface? You used capitalized version right below, so just checking
for consistency.

[kenrb, 2015/05/29 19:29:36]

Done.

+  bool use_surfaces_;
+
+  // Surface-related state.
+  scoped_ptr<cc::SurfaceIdAllocator> id_allocator_;
+  scoped_ptr<cc::SurfaceFactory> surface_factory_;
+  cc::SurfaceId surface_id_;
+  uint32 next_surface_sequence_;
+  uint32 last_output_surface_id_;
+  gfx::Size current_surface_size_;
+  float current_surface_scale_factor_;
+  uint32 ack_pending_count_;

[nasko, 2015/05/28 20:42:36]

nit: All other variables have some sort of "surface" substring in them. Should
this one have too?

[kenrb, 2015/05/29 19:29:36]

It is tracking expected CompositorFrameAcks. It is only used on the context of
surfaces but I think the name is fine for what it is.

+  cc::ReturnedResourceArray surface_returned_resources_;
+
   // frame_connector_ provides a platform abstraction. Messages
   // sent through it are routed to the embedding renderer process.
   CrossProcessFrameConnector* frame_connector_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewChildFrame);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_