Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: content/test/data/browser_plugin_embedder.html

Issue 10941042: Browser plugin: Implement loadStart and loadAbort events (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge with ToT Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/data/browser_plugin_embedder.html
diff --git a/content/test/data/browser_plugin_embedder.html b/content/test/data/browser_plugin_embedder.html
index fb70190a767173c43b5f411923db241b084328da..dcf150c13eda6044365472d8f1f99fa8a1c0fc85 100644
--- a/content/test/data/browser_plugin_embedder.html
+++ b/content/test/data/browser_plugin_embedder.html
@@ -1,7 +1,12 @@
<script type="text/javascript">
+var url;
Charlie Reis 2012/10/03 01:52:30 nit: loadStartUrl That will make the test more obv
Fady Samuel 2012/10/04 00:43:38 Done.
+function loadStart(event) {
+ url = event.url;
+}
function SetSrc(src) {
var plugin = document.getElementById('plugin');
plugin.src = src;
+ plugin.addEventListener('loadStart', loadStart);
}
function SetSize(w, h) {
var plugin = document.getElementById('plugin');
@@ -20,6 +25,7 @@ function Go(relativeIndex) {
var plugin = document.getElementById('plugin');
plugin.go(relativeIndex);
}
+
Charlie Reis 2012/10/03 01:52:30 nit: Remove. (No need for extra code churn.)
Fady Samuel 2012/10/04 00:43:38 Done.
</script>
<object id="plugin"

Powered by Google App Engine
This is Rietveld 408576698