Browser plugin: Implement loadStart and loadAbort events

content/common/browser_plugin_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message header, no traditional include guard.
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/process.h"
@@ skipping 107 matching lines @@
 // A embedder sends this message to the browser when it wants
 // to resize a guest plugin container so that the guest is relaid out
 // according to the new size.
 IPC_SYNC_MESSAGE_ROUTED2_0(BrowserPluginHostMsg_ResizeGuest,
                            int /* instance_id*/,
                            BrowserPluginHostMsg_ResizeGuest_Params)
 
 // -----------------------------------------------------------------------------
 // These messages are from the browser process to the embedder.
 
+// When the guest begins to load a page, the browser process informs the
+// embedder through the BrowserPluginMsg_LoadStart message.
+IPC_MESSAGE_CONTROL3(BrowserPluginMsg_LoadStart,
+                     int /* instance_id */,
+                     GURL /* url */,
+                     bool /* is_top_level */)
+
+IPC_MESSAGE_CONTROL4(BrowserPluginMsg_LoadAbort,

[Charlie Reis, 2012/10/03 01:52:30]

This should have a comment describing the types, etc.

Also, I don't see anyone sending this message.  (Guess we do need a test for
it.)  :)

[Fady Samuel, 2012/10/04 00:43:38]

Done. Although, I don't know if this is the best possible comment here, please
advise whether I should write something more descriptive. Thanks. I don't
exactly know what the cases are for a load to fail.

+                     int /* instance_id */,
+                     GURL /* url */,
+                     bool /* is_top_level */,
+                     std::string /* type */)
+
 // When the guest navigates, the browser process informs the embedder through
 // the BrowserPluginMsg_DidNavigate message.
 IPC_MESSAGE_CONTROL3(BrowserPluginMsg_DidNavigate,
                      int /* instance_id */,
                      GURL /* url */,
                      int /* process_id */)
 
 // When the guest crashes, the browser process informs the embedder through this
 // message.
 IPC_MESSAGE_CONTROL1(BrowserPluginMsg_GuestCrashed,
@@ skipping 45 matching lines @@
 IPC_MESSAGE_CONTROL2(BrowserPluginMsg_ShouldAcceptTouchEvents,
                      int /* instance_id */,
                      bool /* accept */)
 
 // The guest has damage it wants to convey to the embedder so that it can
 // update its backing store.
 IPC_MESSAGE_CONTROL3(BrowserPluginMsg_UpdateRect,
                      int /* instance_id */,
                      int /* message_id */,
                      BrowserPluginMsg_UpdateRect_Params)