Remove LocalStorage runtime flag (status=stable) for chromium

Remove LocalStorage runtime flag (status=stable) for chromium

The feature is in stable status since 2013. No runtime check in blink
currently. So just remove the call for runtime enabling.

The blink side patch is at: https://codereview.chromium.org/1074943004/

BUG=402536
Committed: https://crrev.com/1a041b8c553e1287b464efd3974a9bcd4dd03145
Cr-Commit-Position: refs/heads/master@{#326818}

[qiankun, 2015-04-22 10:42:09]

qiankun.miao@intel.com changed reviewers:
+ avi@chromium.org

[qiankun, 2015-04-22 10:42:09]

PTAL.

[Mike West, 2015-04-22 13:07:41]

mkwst@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2015-04-22 13:07:41]

There's a good deal more piping that you'll want to remove. Start with the
switch itself, then look at the various `local_storage_enabled` bits in
WebPreferences and etc.

[qiankun, 2015-04-22 16:25:12]

On 2015/04/22 13:07:41, Mike West wrote:
> There's a good deal more piping that you'll want to remove. Start with the
> switch itself, then look at the various `local_storage_enabled` bits in
> WebPreferences and etc.

Settings::localStorageEnabled() is still used. We cannot remove such code
currently. Please look at:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

So, I only remove runtime feature path
(RuntimeEnabledFeatures::localStorageEnabled())in this CL.

[qiankun, 2015-04-24 10:30:05]

On 2015/04/22 16:25:12, qiankun wrote:
> On 2015/04/22 13:07:41, Mike West wrote:
> > There's a good deal more piping that you'll want to remove. Start with the
> > switch itself, then look at the various `local_storage_enabled` bits in
> > WebPreferences and etc.
> 
> Settings::localStorageEnabled() is still used. We cannot remove such code
> currently. Please look at:
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> 
> So, I only remove runtime feature path
> (RuntimeEnabledFeatures::localStorageEnabled())in this CL.

Hi mike, what do you think about the flag in settings? Do we need to remove it
or keep it as-is?

[Mike West, 2015-04-24 14:02:39]

On 2015/04/24 at 10:30:05, qiankun.miao wrote:
> On 2015/04/22 16:25:12, qiankun wrote:
> > On 2015/04/22 13:07:41, Mike West wrote:
> > > There's a good deal more piping that you'll want to remove. Start with the
> > > switch itself, then look at the various `local_storage_enabled` bits in
> > > WebPreferences and etc.
> > 
> > Settings::localStorageEnabled() is still used. We cannot remove such code
> > currently. Please look at:
> >
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> > 
> > So, I only remove runtime feature path
> > (RuntimeEnabledFeatures::localStorageEnabled())in this CL.
> 
> Hi mike, what do you think about the flag in settings? Do we need to remove it
or keep it as-is?

LGTM.

We apparently still use this setting to distinguish platform apps from regular
websites. I think it would be nice to drop the command-line flag if we don't
actually need it, but I'm fine with leaving it in in this CL.

You'll still need a //content OWNER to stamp this CL. Perhaps avi@ can do the
honors?

[Avi (use Gerrit), 2015-04-24 15:04:24]

lgtm

[qiankun, 2015-04-24 16:02:58]

The CQ bit was checked by qiankun.miao@intel.com

[commit-bot: I haz the power, 2015-04-24 16:03:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1094103007/1

[commit-bot: I haz the power, 2015-04-24 16:50:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-04-24 16:51:11]

Patchset 1 (id:??) landed as
https://crrev.com/1a041b8c553e1287b464efd3974a9bcd4dd03145
Cr-Commit-Position: refs/heads/master@{#326818}