Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: chrome/browser/signin/signin_error_notifier_ash_unittest.cc

Issue 1094103005: Profile chooser on mac was passing wrong value to signin error controller. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/signin_error_notifier_ash_unittest.cc
diff --git a/chrome/browser/signin/signin_error_notifier_ash_unittest.cc b/chrome/browser/signin/signin_error_notifier_ash_unittest.cc
index 8cd42ef3f6a89b6575e251b2733ca2f2dd40fa14..dfa4fbbf1f5c9454eef30f68f97e24f8e2427713 100644
--- a/chrome/browser/signin/signin_error_notifier_ash_unittest.cc
+++ b/chrome/browser/signin/signin_error_notifier_ash_unittest.cc
@@ -36,7 +36,6 @@ namespace test {
namespace {
static const char kTestAccountId[] = "testuser@test.com";
-static const char kTestUsername[] = "testuser@test.com";
// Notification ID corresponding to kProfileSigninNotificationId +
// kTestAccountId.
@@ -143,7 +142,6 @@ TEST_F(SigninErrorNotifierTest, ErrorAuthStatusProvider) {
FakeAuthStatusProvider error_provider(error_controller_);
error_provider.SetAuthError(
kTestAccountId,
- kTestUsername,
GoogleServiceAuthError(
GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS));
ASSERT_TRUE(notification_ui_manager_->FindById(
@@ -174,7 +172,6 @@ TEST_F(SigninErrorNotifierTest, MAYBE_AuthStatusProviderErrorTransition) {
FakeAuthStatusProvider provider1(error_controller_);
provider0.SetAuthError(
kTestAccountId,
- kTestUsername,
GoogleServiceAuthError(
GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS));
ASSERT_TRUE(notification_ui_manager_->FindById(
@@ -187,12 +184,10 @@ TEST_F(SigninErrorNotifierTest, MAYBE_AuthStatusProviderErrorTransition) {
// Now set another auth error and clear the original.
provider1.SetAuthError(
kTestAccountId,
- kTestUsername,
GoogleServiceAuthError(
GoogleServiceAuthError::UNEXPECTED_SERVICE_RESPONSE));
provider0.SetAuthError(
kTestAccountId,
- kTestUsername,
GoogleServiceAuthError::AuthErrorNone());
ASSERT_TRUE(notification_ui_manager_->FindById(
@@ -205,7 +200,7 @@ TEST_F(SigninErrorNotifierTest, MAYBE_AuthStatusProviderErrorTransition) {
ASSERT_NE(new_message, message);
provider1.SetAuthError(
- kTestAccountId, kTestUsername, GoogleServiceAuthError::AuthErrorNone());
+ kTestAccountId, GoogleServiceAuthError::AuthErrorNone());
ASSERT_FALSE(notification_ui_manager_->FindById(
kNotificationId, NotificationUIManager::GetProfileID(profile_.get())));
}
@@ -242,7 +237,6 @@ TEST_F(SigninErrorNotifierTest, AuthStatusEnumerateAllErrors) {
for (size_t i = 0; i < arraysize(table); ++i) {
FakeAuthStatusProvider provider(error_controller_);
provider.SetAuthError(kTestAccountId,
- kTestUsername,
GoogleServiceAuthError(table[i].error_state));
const Notification* notification = notification_ui_manager_->FindById(
kNotificationId, NotificationUIManager::GetProfileID(profile_.get()));
« no previous file with comments | « chrome/browser/app_controller_mac_unittest.mm ('k') | chrome/browser/signin/signin_global_error_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698