chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm - Issue 1094103005: Profile chooser on mac was passing wrong value to signin error controller.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

Issue 1094103005: Profile chooser on mac was passing wrong value to signin error controller. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix ASI Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/sync_ui_util_unittest.cc ('k') | chrome/browser/ui/views/profiles/profile_chooser_view.cc » ('j') | chrome/browser/ui/views/profiles/profile_chooser_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

diff --git a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

index f0e43d60bc8d1f95102cb7aabcdb63e6cb87cce7..c9e866091ed5f0146e9cb974b489704c5a9c3c95 100644

--- a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

+++ b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

@@ -1999,7 +1999,8 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver,

errorController = profiles::GetSigninErrorController(browser_->profile());

Mike Lerman 2015/04/24 19:36:26 Would you be okay changing this to referencing the

Roger Tawa OOO till Jul 10th 2015/04/27 20:31:59 Done.

url = signin::GetReauthURL(

browser_->profile(),

- errorController ? errorController->error_username() : std::string());

+ errorController ? errorController->error_account_id()

+ : std::string());

messageId = IDS_PROFILES_GAIA_REAUTH_TITLE;

break;

default: