Profile chooser on mac was passing wrong value to signin error controller.

components/signin/core/browser/signin_error_controller.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/signin/core/browser/signin_error_controller.h"
 
+#include "components/signin/core/browser/account_tracker_service.h"

[Mike Lerman, 2015/04/24 19:36:27]

Is this include necessary?

[Roger Tawa OOO till Jul 10th, 2015/04/27 20:32:00]

Oops, left over from old code.  Removed.

 #include "components/signin/core/browser/signin_metrics.h"
 
 namespace {
 
 typedef std::set<const SigninErrorController::AuthStatusProvider*>
     AuthStatusProviderSet;
 
 }  // namespace
 
 SigninErrorController::AuthStatusProvider::AuthStatusProvider() {
@@ skipping 40 matching lines @@
        it != provider_set_.end(); ++it) {
     GoogleServiceAuthError error = (*it)->GetAuthStatus();
 
     // Ignore the states we don't want to elevate to the user.
     if (error.state() == GoogleServiceAuthError::NONE ||
         error.state() == GoogleServiceAuthError::CONNECTION_FAILED) {
       continue;
     }
 
     std::string account_id = (*it)->GetAccountId();
-    std::string username = (*it)->GetUsername();
 
     // Prioritize this error if it matches the previous |auth_error_|.
     if (error.state() == prev_state && account_id == prev_account_id) {
       auth_error_ = error;
       error_account_id_ = account_id;
-      error_username_ = username;
       error_changed = true;
       break;
     }
 
     // Use this error if we haven't found one already, but keep looking for the
     // previous |auth_error_| in case there's a match elsewhere in the set.
     if (!error_changed) {
       auth_error_ = error;
       error_account_id_ = account_id;
-      error_username_ = username;
       error_changed = true;
     }
   }
 
   if (!error_changed && prev_state != GoogleServiceAuthError::NONE) {
     // No provider reported an error, so clear the error we have now.
     auth_error_ = GoogleServiceAuthError::AuthErrorNone();
     error_account_id_.clear();
-    error_username_.clear();
     error_changed = true;
   }
 
   if (error_changed) {
     signin_metrics::LogAuthError(auth_error_.state());
     FOR_EACH_OBSERVER(Observer, observer_list_, OnErrorChanged());
   }
 }
 
 bool SigninErrorController::HasError() const {
   return auth_error_.state() != GoogleServiceAuthError::NONE &&
       auth_error_.state() != GoogleServiceAuthError::CONNECTION_FAILED;
 }
 
 void SigninErrorController::AddObserver(Observer* observer) {
   observer_list_.AddObserver(observer);
 }
 
 void SigninErrorController::RemoveObserver(Observer* observer) {
   observer_list_.RemoveObserver(observer);
 }