Profile chooser on mac was passing wrong value to signin error controller.

chrome/browser/ui/views/profiles/profile_chooser_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/profiles/profile_chooser_view.h"
 
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
@@ skipping 101 matching lines @@
   bitmap.eraseARGB(0, 0, 0, 0);
   return gfx::ImageSkia::CreateFrom1xBitmap(bitmap);
 }
 
 bool HasAuthError(Profile* profile) {
   const SigninErrorController* error =
       profiles::GetSigninErrorController(profile);
   return error && error->HasError();
 }
 
 std::string GetAuthErrorAccountId(Profile* profile) {

[Mike Lerman, 2015/04/24 19:36:26]

nit: it's odd at that this a helper method, while profile_chooser_controller
uses an inline ternary operator. Not sure where there's a good place to put this
method either, unless it's profile_window.

If it didn't bother you, then it's not that important to move it.

[Roger Tawa OOO till Jul 10th, 2015/04/27 20:31:59]

Make helper function.

   const SigninErrorController* error =
       profiles::GetSigninErrorController(profile);
   if (!error)
     return std::string();
 
   return error->error_account_id();
 }
 
-std::string GetAuthErrorUsername(Profile* profile) {
-  const SigninErrorController* error =
-      profiles::GetSigninErrorController(profile);
-  if (!error)
-    return std::string();
-
-  return error->error_username();
-}
-
 // BackgroundColorHoverButton -------------------------------------------------
 
 // A custom button that allows for setting a background color when hovered over.
 class BackgroundColorHoverButton : public views::LabelButton {
  public:
   BackgroundColorHoverButton(views::ButtonListener* listener,
                              const base::string16& text,
                              const gfx::ImageSkia& icon)
       : views::LabelButton(listener, text) {
     SetImageLabelSpacing(views::kItemLabelSpacing);
@@ skipping 1332 matching lines @@
     case profiles::BUBBLE_VIEW_MODE_GAIA_ADD_ACCOUNT:
       url = signin::GetPromoURL(
           signin_metrics::SOURCE_AVATAR_BUBBLE_ADD_ACCOUNT,
           false /* auto_close */,
           true /* is_constrained */);
       message_id = IDS_PROFILES_GAIA_ADD_ACCOUNT_TITLE;
       break;
     case profiles::BUBBLE_VIEW_MODE_GAIA_REAUTH: {
       DCHECK(HasAuthError(browser_->profile()));
       url = signin::GetReauthURL(browser_->profile(),
-                                 GetAuthErrorUsername(browser_->profile()));
+                                 GetAuthErrorAccountId(browser_->profile()));
       message_id = IDS_PROFILES_GAIA_REAUTH_TITLE;
       break;
     }
     default:
       NOTREACHED() << "Called with invalid mode=" << view_mode_;
       return NULL;
   }
 
   // Adds Gaia signin webview
   Profile* profile = browser_->profile();
@@ skipping 209 matching lines @@
       IncognitoModePrefs::GetAvailability(browser_->profile()->GetPrefs()) !=
           IncognitoModePrefs::DISABLED;
   return incognito_available && !browser_->profile()->IsGuestSession();
 }
 
 void ProfileChooserView::PostActionPerformed(
     ProfileMetrics::ProfileDesktopMenu action_performed) {
   ProfileMetrics::LogProfileDesktopMenu(action_performed, gaia_service_type_);
   gaia_service_type_ = signin::GAIA_SERVICE_TYPE_NONE;
 }