Profile chooser on mac was passing wrong value to signin error controller.

chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 #import <Carbon/Carbon.h>  // kVK_Return.
 
 #import "chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h"
 
 #include "base/mac/bundle_locations.h"
@@ skipping 1978 matching lines @@
       break;
     case profiles::BUBBLE_VIEW_MODE_GAIA_ADD_ACCOUNT:
       url = signin::GetPromoURL(
           signin_metrics::SOURCE_AVATAR_BUBBLE_ADD_ACCOUNT,
           false /* auto_close */,
           true /* is_constrained */);
       messageId = IDS_PROFILES_GAIA_ADD_ACCOUNT_TITLE;
       break;
     case profiles::BUBBLE_VIEW_MODE_GAIA_REAUTH:
       DCHECK(HasAuthError(browser_->profile()));
       errorController = profiles::GetSigninErrorController(browser_->profile());

[Mike Lerman, 2015/04/24 19:36:26]

Would you be okay changing this to referencing the SigninErrorControllerFactory
instead of the method in profiles_state? It'd be great to move away from having
that helper method in profiles_state, now that we have a nice PKS. (both here
and in the ProfileChooserView)

[Roger Tawa OOO till Jul 10th, 2015/04/27 20:31:59]

Done.

       url = signin::GetReauthURL(
           browser_->profile(),
-          errorController ? errorController->error_username() : std::string());
+          errorController ? errorController->error_account_id()
+                          : std::string());
       messageId = IDS_PROFILES_GAIA_REAUTH_TITLE;
       break;
     default:
       NOTREACHED() << "Called with invalid mode=" << viewMode_;
       break;
   }
 
   webContents_.reset(content::WebContents::Create(
       content::WebContents::CreateParams(browser_->profile())));
 
@@ skipping 298 matching lines @@
 }
 
 - (bool)shouldShowGoIncognito {
   bool incognitoAvailable =
       IncognitoModePrefs::GetAvailability(browser_->profile()->GetPrefs()) !=
           IncognitoModePrefs::DISABLED;
   return incognitoAvailable && !browser_->profile()->IsGuestSession();
 }
 
 @end