Profile chooser on mac was passing wrong value to signin error controller.

chrome/browser/signin/signin_error_notifier_ash_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/signin/signin_error_notifier_ash.h"
 
 #include "ash/test/ash_test_base.h"
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/notifications/notification.h"
@@ skipping 18 matching lines @@
 #include "ui/gfx/screen.h"
 #include "ui/gfx/screen_type_delegate.h"
 #endif
 
 namespace ash {
 namespace test {
 
 namespace {
 
 static const char kTestAccountId[] = "testuser@test.com";
-static const char kTestUsername[] = "testuser@test.com";
 
 // Notification ID corresponding to kProfileSigninNotificationId +
 // kTestAccountId.
 static const std::string kNotificationId =
     "chrome://settings/signin/testuser@test.com";
 }
 
 #if defined(OS_WIN)
 class ScreenTypeDelegateDesktop : public gfx::ScreenTypeDelegate {
  public:
@@ skipping 87 matching lines @@
 // Disabled on Win due to flake. http://crbug.com/372236
 TEST_F(SigninErrorNotifierTest, ErrorAuthStatusProvider) {
   {
     FakeAuthStatusProvider provider(error_controller_);
     ASSERT_FALSE(notification_ui_manager_->FindById(
         kNotificationId, NotificationUIManager::GetProfileID(profile_.get())));
     {
       FakeAuthStatusProvider error_provider(error_controller_);
       error_provider.SetAuthError(
           kTestAccountId,
-          kTestUsername,
           GoogleServiceAuthError(
               GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS));
       ASSERT_TRUE(notification_ui_manager_->FindById(
           kNotificationId,
           NotificationUIManager::GetProfileID(profile_.get())));
     }
     // error_provider is removed now that we've left that scope.
     ASSERT_FALSE(notification_ui_manager_->FindById(
         kNotificationId, NotificationUIManager::GetProfileID(profile_.get())));
   }
@@ skipping 10 matching lines @@
 #else
 #define MAYBE_AuthStatusProviderErrorTransition \
   AuthStatusProviderErrorTransition
 #endif
 TEST_F(SigninErrorNotifierTest, MAYBE_AuthStatusProviderErrorTransition) {
   {
     FakeAuthStatusProvider provider0(error_controller_);
     FakeAuthStatusProvider provider1(error_controller_);
     provider0.SetAuthError(
         kTestAccountId,
-        kTestUsername,
         GoogleServiceAuthError(
             GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS));
     ASSERT_TRUE(notification_ui_manager_->FindById(
         kNotificationId, NotificationUIManager::GetProfileID(profile_.get())));
 
     base::string16 message;
     GetMessage(&message);
     ASSERT_FALSE(message.empty());
 
     // Now set another auth error and clear the original.
     provider1.SetAuthError(
         kTestAccountId,
-        kTestUsername,
         GoogleServiceAuthError(
             GoogleServiceAuthError::UNEXPECTED_SERVICE_RESPONSE));
     provider0.SetAuthError(
         kTestAccountId,
-        kTestUsername,
         GoogleServiceAuthError::AuthErrorNone());
 
     ASSERT_TRUE(notification_ui_manager_->FindById(
         kNotificationId, NotificationUIManager::GetProfileID(profile_.get())));
 
     base::string16 new_message;
     GetMessage(&new_message);
     ASSERT_FALSE(new_message.empty());
 
     ASSERT_NE(new_message, message);
 
     provider1.SetAuthError(
-        kTestAccountId, kTestUsername, GoogleServiceAuthError::AuthErrorNone());
+        kTestAccountId, GoogleServiceAuthError::AuthErrorNone());
     ASSERT_FALSE(notification_ui_manager_->FindById(
         kNotificationId, NotificationUIManager::GetProfileID(profile_.get())));
   }
 }
 
 #if !defined(OS_WIN)
 // Disabled on Win due to flake. http://crbug.com/372236
 // Verify that SigninErrorNotifier ignores certain errors.
 TEST_F(SigninErrorNotifierTest, AuthStatusEnumerateAllErrors) {
   typedef struct {
@@ skipping 16 matching lines @@
     { GoogleServiceAuthError::UNEXPECTED_SERVICE_RESPONSE, true },
     { GoogleServiceAuthError::SERVICE_ERROR, true },
     { GoogleServiceAuthError::WEB_LOGIN_REQUIRED, true },
   };
   static_assert(arraysize(table) == GoogleServiceAuthError::NUM_STATES,
       "table size should match number of auth error types");
 
   for (size_t i = 0; i < arraysize(table); ++i) {
     FakeAuthStatusProvider provider(error_controller_);
     provider.SetAuthError(kTestAccountId,
-                          kTestUsername,
                           GoogleServiceAuthError(table[i].error_state));
     const Notification* notification = notification_ui_manager_->FindById(
         kNotificationId, NotificationUIManager::GetProfileID(profile_.get()));
     ASSERT_EQ(table[i].is_error, notification != NULL);
     if (table[i].is_error) {
       EXPECT_FALSE(notification->title().empty());
       EXPECT_FALSE(notification->message().empty());
       EXPECT_EQ((size_t)1, notification->buttons().size());
     }
   }
 }
 #endif
 
 }  // namespace test
 }  // namespace ash