android_webview/browser/DEPS - Issue 10941015: [Android] Upstream the WebView find-in-page API implementation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: android_webview/browser/DEPS

Issue 10941015: [Android] Upstream the WebView find-in-page API implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "-android_webview",	2 "-android_webview",

3 "+android_webview/browser",	3 "+android_webview/browser",

4 "+android_webview/common",	4 "+android_webview/common",

	5

	6 # POD structure required by the find-in-page IPC messages.

	7 "+third_party/WebKit/Source/WebKit/chromium/public/WebFindOptions.h",
	mkosiba (inactive) 2012/09/19 12:28:38 nit: should be OK to simply say "third_party/WebKi nit: should be OK to simply say "third_party/WebKit/Source/WebKit/chromium/public". Leandro Graciá Gil 2012/09/19 12:35:09 I discussed this with joth. The public folder cont Show quoted text On 2012/09/19 12:28:38, Martin Kosiba wrote: > nit: should be OK to simply say > "third_party/WebKit/Source/WebKit/chromium/public". I discussed this with joth. The public folder contains not only POD structures (which are ok in DEPS) but also exposes the API functionality (e.g. WebFrame, WebView... which is not so good in DEPS). We're currently considering the possibility of moving such POD structures to a separate folder in WebKit. For now we decided to explicitly define this exception.
5 ]	8 ]

OLD	NEW