Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart

Issue 1094083002: Revert "dart2js: add type arguments to constructor in case the class needs rti." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js.js_emitter; 5 part of dart2js.js_emitter;
6 6
7 // TODO(ahe): Share these with js_helper.dart. 7 // TODO(ahe): Share these with js_helper.dart.
8 const FUNCTION_INDEX = 0; 8 const FUNCTION_INDEX = 0;
9 const NAME_INDEX = 1; 9 const NAME_INDEX = 1;
10 const CALL_NAME_INDEX = 2; 10 const CALL_NAME_INDEX = 2;
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 226
227 for (var i = 0; i < fields.length; i++) { 227 for (var i = 0; i < fields.length; i++) {
228 if(i != 0) str += ", "; 228 if(i != 0) str += ", ";
229 229
230 var field = generateAccessor(fields[i], accessors, name); 230 var field = generateAccessor(fields[i], accessors, name);
231 if (#hasIsolateSupport) { fieldNames += "'" + field + "',"; } 231 if (#hasIsolateSupport) { fieldNames += "'" + field + "',"; }
232 var parameter = "p_" + field; 232 var parameter = "p_" + field;
233 str += parameter; 233 str += parameter;
234 body += ("this." + field + " = " + parameter + ";\\n"); 234 body += ("this." + field + " = " + parameter + ";\\n");
235 } 235 }
236 // TODO(zarah): Check whether there is any gain in always having this
237 // property and if so, add it unconditionally.
238 body += "if (typeInfo) this.\$builtinTypeInfo = typeInfo;\\n";
239 if (supportsDirectProtoAccess) { 236 if (supportsDirectProtoAccess) {
240 body += "this." + #deferredActionString + "();"; 237 body += "this." + #deferredActionString + "();";
241 } 238 }
242 239 str += ") {\\n" + body + "}\\n";
243 if (fields.length > 0) str += ",";
244 str += "typeInfo) {\\n" + body + "}\\n";
245 str += name + ".builtin\$cls=\\"" + name + "\\";\\n"; 240 str += name + ".builtin\$cls=\\"" + name + "\\";\\n";
246 str += "\$desc=\$collectedClasses." + name + "[1];\\n"; 241 str += "\$desc=\$collectedClasses." + name + "[1];\\n";
247 str += name + ".prototype = \$desc;\\n"; 242 str += name + ".prototype = \$desc;\\n";
248 if (typeof defineClass.name != "string") { 243 if (typeof defineClass.name != "string") {
249 str += name + ".name=\\"" + name + "\\";\\n"; 244 str += name + ".name=\\"" + name + "\\";\\n";
250 } 245 }
251 if (#hasIsolateSupport) { 246 if (#hasIsolateSupport) {
252 str += name + "." + #fieldNamesProperty + "=[" + fieldNames 247 str += name + "." + #fieldNamesProperty + "=[" + fieldNames
253 + "];\\n"; 248 + "];\\n";
254 } 249 }
(...skipping 593 matching lines...) Expand 10 before | Expand all | Expand 10 after
848 (function() { 843 (function() {
849 var result = $array[$index]; 844 var result = $array[$index];
850 if ($check) { 845 if ($check) {
851 throw new Error( 846 throw new Error(
852 name + ": expected value of type \'$type\' at index " + ($index) + 847 name + ": expected value of type \'$type\' at index " + ($index) +
853 " but got " + (typeof result)); 848 " but got " + (typeof result));
854 } 849 }
855 return result; 850 return result;
856 })()'''; 851 })()''';
857 } 852 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/class_stub_generator.dart ('k') | pkg/compiler/lib/src/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698