Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issue 1094063002: [turbofan] split register allocator into little pieces (Closed)

Created:
5 years, 8 months ago by dcarney
Modified:
5 years, 8 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] split register allocator into little pieces R=titzer@chromium.org BUG= Committed: https://crrev.com/497c537310d72064a23bb0ea3e4e708460b7dbf4 Cr-Commit-Position: refs/heads/master@{#27946}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 1

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1201 lines, -1051 lines) Patch
M src/compiler/graph-visualizer.h View 1 2 3 4 5 6 7 2 chunks +8 lines, -7 lines 0 comments Download
M src/compiler/graph-visualizer.cc View 1 2 3 4 5 6 7 3 chunks +9 lines, -8 lines 0 comments Download
M src/compiler/pipeline.cc View 1 2 3 4 5 6 7 20 chunks +65 lines, -29 lines 0 comments Download
M src/compiler/register-allocator.h View 1 2 3 4 5 6 7 8 8 chunks +243 lines, -122 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 2 3 4 5 6 7 40 chunks +876 lines, -885 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
Looks good, just one more slice. https://codereview.chromium.org/1094063002/diff/100001/src/compiler/register-allocator.h File src/compiler/register-allocator.h (right): https://codereview.chromium.org/1094063002/diff/100001/src/compiler/register-allocator.h#newcode533 src/compiler/register-allocator.h:533: const RegisterConfiguration* const ...
5 years, 8 months ago (2015-04-20 13:33:53 UTC) #2
dcarney
On 2015/04/20 13:33:53, titzer wrote: > Looks good, just one more slice. > > https://codereview.chromium.org/1094063002/diff/100001/src/compiler/register-allocator.h ...
5 years, 8 months ago (2015-04-20 14:20:44 UTC) #3
titzer
LGTM although a struct would be soooo much nicer
5 years, 8 months ago (2015-04-20 14:54:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094063002/150001
5 years, 8 months ago (2015-04-20 15:33:51 UTC) #6
commit-bot: I haz the power
Committed patchset #9 (id:150001)
5 years, 8 months ago (2015-04-20 16:15:40 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 16:15:50 UTC) #8
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/497c537310d72064a23bb0ea3e4e708460b7dbf4
Cr-Commit-Position: refs/heads/master@{#27946}

Powered by Google App Engine
This is Rietveld 408576698