Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 109403004: ARM Skia NEON patches - 34 - Blur Filter (Closed)

Created:
7 years ago by kevin.petit.not.used.account
Modified:
7 years ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

ARM Skia NEON patches - 34 - Blur Filter Improve a little on Blur Grouping operations gives a 5-15% speed improvement on a Cortex-A15 based Chromebook. before: running bench [640 480] blur_image_filter_large_10.00_10.00 8888: cmsecs = 30887.69 running bench [640 480] blur_image_filter_small_10.00_10.00 8888: cmsecs = 30751.35 running bench [640 480] blur_image_filter_large_1.00_1.00 8888: cmsecs = 30757.92 running bench [640 480] blur_image_filter_small_1.00_1.00 8888: cmsecs = 30673.88 running bench [640 480] blur_image_filter_large_0.00_1.00 8888: cmsecs = 19602.17 running bench [640 480] blur_image_filter_large_0.00_10.00 8888: cmsecs = 20613.81 running bench [640 480] blur_image_filter_large_1.00_0.00 8888: cmsecs = 17855.46 running bench [640 480] blur_image_filter_large_10.00_0.00 8888: cmsecs = 17957.79 after: running bench [640 480] blur_image_filter_large_10.00_10.00 8888: cmsecs = 27015.75 running bench [640 480] blur_image_filter_small_10.00_10.00 8888: cmsecs = 27148.02 running bench [640 480] blur_image_filter_large_1.00_1.00 8888: cmsecs = 27241.60 running bench [640 480] blur_image_filter_small_1.00_1.00 8888: cmsecs = 27077.44 running bench [640 480] blur_image_filter_large_0.00_1.00 8888: cmsecs = 18458.10 running bench [640 480] blur_image_filter_large_0.00_10.00 8888: cmsecs = 19643.42 running bench [640 480] blur_image_filter_large_1.00_0.00 8888: cmsecs = 16176.73 running bench [640 480] blur_image_filter_large_10.00_0.00 8888: cmsecs = 16450.50 Signed-off-by: Kévin PETIT <kevin.petit@arm.com>; BUG= Committed: http://code.google.com/p/skia/source/detail?r=12568

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M src/opts/SkBlurImage_opts_neon.cpp View 3 chunks +12 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kevin.petit.not.used.account
Hello, After reviewing https://codereview.chromium.org/99933004, I found a few easy improvements to do. May I suggest ...
7 years ago (2013-12-09 15:17:09 UTC) #1
Stephen White
On 2013/12/09 15:17:09, kevin.petit.arm wrote: > Hello, > > After reviewing https://codereview.chromium.org/99933004, I found a ...
7 years ago (2013-12-09 15:38:53 UTC) #2
Stephen White
LGTM
7 years ago (2013-12-09 15:40:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kevin.petit.arm@gmail.com/109403004/1
7 years ago (2013-12-09 15:51:08 UTC) #4
commit-bot: I haz the power
Change committed as 12568
7 years ago (2013-12-09 16:03:33 UTC) #5
robertphillips
This was reverted in r12578 due to N4 image quality regressions
7 years ago (2013-12-09 20:16:42 UTC) #6
robertphillips
7 years ago (2013-12-09 20:35:43 UTC) #7
Message was sent while issue was closed.
Sorry. I mistakenly believe this patch was responsible for some image
regressions. I have relanded it at r12581.

Powered by Google App Engine
This is Rietveld 408576698