components/password_manager/core/browser/password_form_manager.h - Issue 1094013002: PasswordFormManager: Clean up PasswordForm pointer ownership.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 1094013002: PasswordFormManager: Clean up PasswordForm pointer ownership. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@image-scopedptr

Patch Set: Revert back to using a reference (minimize map lookups). Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/password_manager/core/browser/password_form_manager.h

diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h

index 2da08e0e7004a1fbd0a7a6aa437a82bb6301cdb9..aa0d9e25f9dac1a8f6034eb21fd4f87ae9d533a8 100644

--- a/components/password_manager/core/browser/password_form_manager.h

+++ b/components/password_manager/core/browser/password_form_manager.h

@@ -10,6 +10,7 @@

#include "build/build_config.h"

+#include "base/memory/scoped_ptr.h"

#include "base/memory/weak_ptr.h"

#include "base/stl_util.h"

#include "components/autofill/core/browser/field_types.h"

« no previous file with comments | « no previous file | components/password_manager/core/browser/password_form_manager.cc » ('j') | no next file with comments »