Source/core/css/parser/CSSParser.cpp - Issue 1094003002: CSSStyleDeclaration::setProperty should override important style

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSParser.cpp

Issue 1094003002: CSSStyleDeclaration::setProperty should override important style (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review feedback Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/parser/CSSParser.cpp

diff --git a/Source/core/css/parser/CSSParser.cpp b/Source/core/css/parser/CSSParser.cpp

index 4c9cf16e7232c85428b83b211c882703a892732e..764412343b51a10a43d198581c1fcf323886d5a8 100644

--- a/Source/core/css/parser/CSSParser.cpp

+++ b/Source/core/css/parser/CSSParser.cpp

@@ -64,7 +64,7 @@ bool CSSParser::parseValue(MutableStylePropertySet* declaration, CSSPropertyID u

CSSPropertyID resolvedProperty = resolveCSSPropertyID(unresolvedProperty);

RefPtrWillBeRawPtr<CSSValue> value = CSSParserFastPaths::maybeParseValue(resolvedProperty, string, parserMode);

if (value)

- return declaration->addParsedProperty(CSSProperty(resolvedProperty, value.release(), important));

+ return declaration->setProperty(CSSProperty(resolvedProperty, value.release(), important));

CSSParserContext context(parserMode, 0);

if (styleSheet) {

context = styleSheet->parserContext();

« no previous file with comments | « Source/core/css/StylePropertySet.cpp ('k') | Source/core/css/resolver/ViewportStyleResolver.cpp » ('j') | no next file with comments »