Fix mock restoration in git_cl_test

Fix mock restoration in git_cl_test

The assertion in TestGitCl.tearDown should be done after super.tearDown
is finished. Otherwise if the assertion fails, mocked objects won't be
restored properly, and the next TestCase would be affected.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295049

[wychen, 2015-04-18 02:20:00]

wychen@chromium.org changed reviewers:
+ maruel@chromium.org

[wychen, 2015-04-18 02:20:00]

PTAL

[M-A Ruel, 2015-04-19 19:32:28]

https://codereview.chromium.org/1093943002/diff/1/tests/git_cl_test.py
File tests/git_cl_test.py (right):

https://codereview.chromium.org/1093943002/diff/1/tests/git_cl_test.py#newcod...
tests/git_cl_test.py:105: if not self.has_failed():
In general; I do:

try:
  <cleanup>
finally:
  super(TestGitCl, self).tearDown()

but yours works too so lgtm

[wychen, 2015-04-20 17:44:43]

wychen@chromium.org changed reviewers:
+ iannucci@chromium.org

[wychen, 2015-04-20 17:44:44]

https://codereview.chromium.org/1093943002/diff/1/tests/git_cl_test.py
File tests/git_cl_test.py (right):

https://codereview.chromium.org/1093943002/diff/1/tests/git_cl_test.py#newcod...
tests/git_cl_test.py:105: if not self.has_failed():
On 2015/04/19 19:32:28, M-A Ruel wrote:
> In general; I do:
> 
> try:
>   <cleanup>
> finally:
>   super(TestGitCl, self).tearDown()
> 
> but yours works too so lgtm

This does look more readable. Modified to your style.

[wychen, 2015-04-28 23:26:24]

The CQ bit was checked by wychen@chromium.org

[wychen, 2015-04-28 23:26:24]

The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/1093943002/#ps20001
(title: "address maruel's comment")

[commit-bot: I haz the power, 2015-04-28 23:26:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1093943002/20001

[commit-bot: I haz the power, 2015-04-28 23:30:07]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295049