Issue 109393003: [webcrypto] Refactor some of the algorithm parameter names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 109393003: [webcrypto] Refactor some of the algorithm parameter names. (Closed)

Created:
7 years ago by eroman

Modified:
7 years ago

Reviewers:
abarth-chromium

CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium, padolph

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

[webcrypto] Refactor some of the algorithm parameter names. (1) Add a suffix of either "Bits" or "Bytes" to all lengths to help with misuse. [*] (2) Change how optional parameters are retrieved. Currently they require a getter, to prevent misuse [*]. However this is inconvenient, especially for buffers. Naming them "optional" should be enough to guide proper usage. [*] There was a bug attempting to do this caught in a codereview. BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163691

Patch Set 1 #

Patch Set 2 : Improve a comment #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -58 lines)			Patch
M	Source/modules/crypto/AesCtrParams.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/crypto/AesKeyGenParams.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/crypto/HmacKeyParams.cpp	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	Source/modules/crypto/RsaKeyGenParams.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	public/platform/WebCryptoAlgorithmParams.h	View	1	5 chunks	+52 lines, -52 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/109393003/10001

7 years ago (2013-12-11 07:43:21 UTC) #3

Message was sent while issue was closed.

Change committed as 163691

Expand Messages | Collapse Messages