Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 1093923006: Compile File Manager Private API on Chrome OS only. (Closed)

Created:
5 years, 8 months ago by mtomasz
Modified:
5 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Compile File Manager Private API on Chrome OS only. This API is used on Chrome OS only. No need to compile the schema on all operating systems. TEST=All current Files app tests pass. BUG=None Committed: https://crrev.com/da67bae38f2a912e67b4dd3eb1554b49d620156f Cr-Commit-Position: refs/heads/master@{#326821}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/common/extensions/api/schemas.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtomasz
@kalman: PTAL. Thanks.
5 years, 8 months ago (2015-04-24 12:51:14 UTC) #2
not at google - send to devlin
lgtm
5 years, 8 months ago (2015-04-24 16:40:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093923006/1
5 years, 8 months ago (2015-04-24 17:02:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 17:05:54 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 17:06:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da67bae38f2a912e67b4dd3eb1554b49d620156f
Cr-Commit-Position: refs/heads/master@{#326821}

Powered by Google App Engine
This is Rietveld 408576698