Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 1093923004: Telemetry: Re-enable ServiceWorkerPerfTest, increase timeout for VideoRecorder.IsStarted (Closed)

Created:
5 years, 8 months ago by Kunihiko Sakamoto
Modified:
5 years, 8 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org, serviceworker-reviews, oystein (OOO til 10th of July), eakuefner, Yufeng Shen (Slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Telemetry: Re-enable ServiceWorkerPerfTest, increase timeout for VideoRecorder.IsStarted ServiceWorkerPerfTest was failing on Android One, due to timeouts of VideoRecorder.IsStarted(). This patch attempts to fix this by increasing the timeout from 5 seconds to 10 seconds, and re-enable the test. BUG=469841 TEST=tools/perf/run_benchmark --browser=trybot-all-android service_worker.service_worker Committed: https://crrev.com/42ce01867659573b37b46df12a3db18ba26674b9 Cr-Commit-Position: refs/heads/master@{#326820}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M tools/perf/benchmarks/service_worker.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Kunihiko Sakamoto
5 years, 8 months ago (2015-04-24 09:33:54 UTC) #2
sullivan
lgtm cc-ing Oystein and Ethan who've been trying to figure out the issue from our ...
5 years, 8 months ago (2015-04-24 15:13:45 UTC) #3
sullivan
cc-ing miletus, current perf sheriff This passed on the perf trybots: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/68 I'm going to ...
5 years, 8 months ago (2015-04-24 16:02:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093923004/1
5 years, 8 months ago (2015-04-24 16:03:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 17:02:33 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/42ce01867659573b37b46df12a3db18ba26674b9 Cr-Commit-Position: refs/heads/master@{#326820}
5 years, 8 months ago (2015-04-24 17:03:23 UTC) #8
Kunihiko Sakamoto
5 years, 8 months ago (2015-04-27 06:41:14 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1099033005/ by ksakamoto@chromium.org.

The reason for reverting is: It still times out:
http://build.chromium.org/p/chromium.perf/builders/Android%20One%20Perf/build...
.

Powered by Google App Engine
This is Rietveld 408576698