Issue 10939019: [filemanager] HiDPI icon for filemanager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10939019: [filemanager] HiDPI icon for filemanager. (Closed)

Created:
8 years, 3 months ago by dgozman

Modified:
8 years, 3 months ago

Reviewers:
Vladislav Kaznacheev

CC:
chromium-reviews, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

[filemanager] HiDPI icon for filemanager. BUG=135169 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157353

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
M	chrome/browser/resources/component_extension_resources.grd	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/css/action_choice.css	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
A	chrome/browser/resources/file_manager/images/icon32.png	View		Binary file		0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vladislav Kaznacheev

If you put quotes around the image urls in CSS they will be inlined as ...

8 years, 3 months ago (2012-09-18 14:41:01 UTC) #2

dgozman

8 years, 3 months ago (2012-09-18 14:45:29 UTC) #3

On Tue, Sep 18, 2012 at 6:41 PM, <kaznacheev@chromium.org> wrote:

> If you put quotes around the image urls in CSS they will be inlined as
> data urls
> and there will no need to change component_extension_resources.**grd.
>
Ok.


>
> LGTM
>
>
https://chromiumcodereview.**appspot.com/10939019/<https://chromiumcodereview...
>

Expand Messages | Collapse Messages