Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Unified Diff: lib/compiler/implementation/ssa/builder.dart

Issue 10939016: Add missing space in error message for missing constructor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/builder.dart
diff --git a/lib/compiler/implementation/ssa/builder.dart b/lib/compiler/implementation/ssa/builder.dart
index 9baeb6c6ddfbdb3ce9db6e3800a32d700b716432..e6c5a9c802270d225b3d950ed932003171160720 100644
--- a/lib/compiler/implementation/ssa/builder.dart
+++ b/lib/compiler/implementation/ssa/builder.dart
@@ -2014,8 +2014,12 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
return pop();
}
- String getTargetName(ErroneousElement error, [String prefix = '']) {
- return '$prefix${error.targetName.slowToString()}';
+ String getTargetName(ErroneousElement error, [String prefix]) {
+ String result = error.targetName.slowToString();
+ if (?prefix) {
+ result = '$prefix $result';
+ }
+ return result;
}
void generateInstanceGetterWithCompiledReceiver(Send send,
@@ -2072,7 +2076,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
} else if (Elements.isErroneousElement(element)) {
// An erroneous element indicates an unresolved static getter.
generateThrowNoSuchMethod(send,
- getTargetName(element, 'get '),
+ getTargetName(element, 'get'),
const EmptyLink<Node>());
} else {
stack.add(localsHandler.readLocal(element));
@@ -2119,7 +2123,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
} else if (Elements.isErroneousElement(element)) {
// An erroneous element indicates an unresolved static setter.
generateThrowNoSuchMethod(send,
- getTargetName(element, 'set '),
+ getTargetName(element, 'set'),
send.arguments);
} else {
stack.add(value);
@@ -3202,7 +3206,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
HInstruction oldVariable = pop();
if (variable.isErroneous()) {
generateThrowNoSuchMethod(node,
- getTargetName(variable, 'set '),
+ getTargetName(variable, 'set'),
argumentValues: <HInstruction>[oldVariable]);
pop();
} else {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698