Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: ui/aura/root_window_host_win.cc

Issue 10939006: Make cursors work on win aura. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | ui/base/cursor/cursor_loader_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/root_window_host_win.cc
===================================================================
--- ui/aura/root_window_host_win.cc (revision 157487)
+++ ui/aura/root_window_host_win.cc (working copy)
@@ -12,6 +12,7 @@
#include "ui/aura/client/capture_client.h"
#include "ui/aura/env.h"
#include "ui/aura/root_window.h"
+#include "ui/base/cursor/cursor_loader_win.h"
#include "ui/base/events/event.h"
#include "ui/base/view_prop.h"
@@ -24,87 +25,6 @@
const char* kRootWindowHostWinKey = "__AURA_ROOT_WINDOW_HOST_WIN__";
-// TODO(mazda): Move the cursor code to ui/base/cursor/cursor_loader_win.{cc,h}.
-const wchar_t* GetCursorId(gfx::NativeCursor native_cursor) {
- switch (native_cursor.native_type()) {
- case ui::kCursorNull:
- return IDC_ARROW;
- case ui::kCursorPointer:
- return IDC_ARROW;
- case ui::kCursorCross:
- return IDC_CROSS;
- case ui::kCursorHand:
- return IDC_HAND;
- case ui::kCursorIBeam:
- return IDC_IBEAM;
- case ui::kCursorWait:
- return IDC_WAIT;
- case ui::kCursorHelp:
- return IDC_HELP;
- case ui::kCursorEastResize:
- return IDC_SIZEWE;
- case ui::kCursorNorthResize:
- return IDC_SIZENS;
- case ui::kCursorNorthEastResize:
- return IDC_SIZENESW;
- case ui::kCursorNorthWestResize:
- return IDC_SIZENWSE;
- case ui::kCursorSouthResize:
- return IDC_SIZENS;
- case ui::kCursorSouthEastResize:
- return IDC_SIZENWSE;
- case ui::kCursorSouthWestResize:
- return IDC_SIZENESW;
- case ui::kCursorWestResize:
- return IDC_SIZEWE;
- case ui::kCursorNorthSouthResize:
- return IDC_SIZENS;
- case ui::kCursorEastWestResize:
- return IDC_SIZEWE;
- case ui::kCursorNorthEastSouthWestResize:
- return IDC_SIZENESW;
- case ui::kCursorNorthWestSouthEastResize:
- return IDC_SIZENWSE;
- case ui::kCursorMove:
- return IDC_SIZEALL;
- case ui::kCursorProgress:
- return IDC_APPSTARTING;
- case ui::kCursorNoDrop:
- return IDC_NO;
- case ui::kCursorNotAllowed:
- return IDC_NO;
- case ui::kCursorColumnResize:
- case ui::kCursorRowResize:
- case ui::kCursorMiddlePanning:
- case ui::kCursorEastPanning:
- case ui::kCursorNorthPanning:
- case ui::kCursorNorthEastPanning:
- case ui::kCursorNorthWestPanning:
- case ui::kCursorSouthPanning:
- case ui::kCursorSouthEastPanning:
- case ui::kCursorSouthWestPanning:
- case ui::kCursorWestPanning:
- case ui::kCursorVerticalText:
- case ui::kCursorCell:
- case ui::kCursorContextMenu:
- case ui::kCursorAlias:
- case ui::kCursorCopy:
- case ui::kCursorNone:
- case ui::kCursorZoomIn:
- case ui::kCursorZoomOut:
- case ui::kCursorGrab:
- case ui::kCursorGrabbing:
- case ui::kCursorCustom:
- // TODO(jamescook): Should we use WebKit glue resources for these?
- // Or migrate those resources to someplace ui/aura can share?
- NOTIMPLEMENTED();
- return IDC_ARROW;
- default:
- NOTREACHED();
- return IDC_ARROW;
- }
-}
-
} // namespace
// static
@@ -232,10 +152,10 @@
// Custom web cursors are handled directly.
if (native_cursor == ui::kCursorCustom)
return;
- const wchar_t* cursor_id = GetCursorId(native_cursor);
- // TODO(jamescook): Support for non-system cursors will require finding
- // the appropriate module to pass to LoadCursor().
- ::SetCursor(LoadCursor(NULL, cursor_id));
+
+ ui::CursorLoaderWin cursor_loader;
+ cursor_loader.SetPlatformCursor(&native_cursor);
+ ::SetCursor(native_cursor.platform());
}
void RootWindowHostWin::SetCapture() {
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | ui/base/cursor/cursor_loader_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698