Issue 10939006: Make cursors work on win aura.

Issue 10939006: Make cursors work on win aura. (Closed)

Created:
8 years, 3 months ago by jam

Modified:
8 years, 3 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Make cursors work on win aura. BUG=146077 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157553

Patch Set 5 : fix win build and review comment #

Patch Set 6 : remove file that's not part of this change #

Patch Set 7 : sync and remove from cros/non-aura builds #

Patch Set 8 : cleanup views.gyp! #

Patch Set 9 : rietveld mess up #

Patch Set 11 : sync #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+252 lines, -152 lines)			Patch
M	chrome/browser/ui/views/chrome_views_delegate.cc	View	1 2 3 4 5 6 7 8 9	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_aura.cc	View	1 2 3 4 5 6 7 8 9	2 chunks	+6 lines, -2 lines	0 comments	Download
M	ui/aura/root_window_host_win.cc	View	1 2 3 4 5 6 7 8 9	3 chunks	+5 lines, -85 lines	0 comments	Download
M	ui/base/cursor/cursor_loader_win.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/cursor/cursor_loader_win.cc	View	1 2 3 4 5 6 7 8 9	2 chunks	+97 lines, -1 line	0 comments	Download
M	ui/views/view.cc	View	1 2 3 4 5 6 7 8 9	1 chunk	+8 lines, -1 line	0 comments	Download
M	ui/views/views.gyp	View	1 2 3 4 5 6 7 8 9 10	2 chunks	+6 lines, -2 lines	0 comments	Download
M	ui/views/widget/desktop_native_widget_aura.cc	View	1 2 3 4 5 6 7 8 9	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/widget/desktop_native_widget_helper_aura.cc	View	1 2 3 4 5 6 7 8 9	5 chunks	+6 lines, -60 lines	0 comments	Download
M	ui/views/widget/desktop_root_window_host_win.h	View	1 2 3 4 5 6 7 8 9	2 chunks	+11 lines, -0 lines	0 comments	Download
M	ui/views/widget/desktop_root_window_host_win.cc	View	1 2 3 4 5 6 7 8 9	3 chunks	+18 lines, -0 lines	0 comments	Download
A	ui/views/widget/desktop_screen_position_client.h	View	1 2 3 4	1 chunk	+33 lines, -0 lines	0 comments	Download
A	ui/views/widget/desktop_screen_position_client.cc	View	1 2 3 4	1 chunk	+58 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tfarina

https://codereview.chromium.org/10939006/diff/3005/ui/views/widget/desktop_screen_position_client_aura.h File ui/views/widget/desktop_screen_position_client_aura.h (right): https://codereview.chromium.org/10939006/diff/3005/ui/views/widget/desktop_screen_position_client_aura.h#newcode8 ui/views/widget/desktop_screen_position_client_aura.h:8: #include "ui/aura/client/screen_position_client.h" could you add basictypes.h and compiler_specific (for ...

8 years, 3 months ago (2012-09-18 01:04:47 UTC) #2

Ben Goodger (Google)

lgtm https://codereview.chromium.org/10939006/diff/15002/ui/views/widget/desktop_screen_position_client_aura.h File ui/views/widget/desktop_screen_position_client_aura.h (right): https://codereview.chromium.org/10939006/diff/15002/ui/views/widget/desktop_screen_position_client_aura.h#newcode5 ui/views/widget/desktop_screen_position_client_aura.h:5: #ifndef UI_VIEWS_WIDGET_DESKTOP_SCREEN_POSITION_CLIENT_AURA_H_ -aura from the filename

8 years, 3 months ago (2012-09-18 02:18:21 UTC) #3

jam

8 years, 3 months ago (2012-09-18 04:48:47 UTC) #4

https://codereview.chromium.org/10939006/diff/15002/ui/views/widget/desktop_s...
File ui/views/widget/desktop_screen_position_client_aura.h (right):

https://codereview.chromium.org/10939006/diff/15002/ui/views/widget/desktop_s...
ui/views/widget/desktop_screen_position_client_aura.h:5: #ifndef
UI_VIEWS_WIDGET_DESKTOP_SCREEN_POSITION_CLIENT_AURA_H_
On 2012/09/18 02:18:21, Ben Goodger (Google) wrote:
> -aura from the filename

I'm a little confused, why not aura in the filename? Is that because this target
is only built for aura anyways? if so, how come other files in that directory
have aura suffixes? or is that because eventually that'll be the case?

Expand Messages | Collapse Messages