Remove API keys from source.

Remove API keys from source.
Also fixes a bug in google_api_keys that made it fail when used as a module.

BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157405

[Jamie, 2012-09-18 00:47:52]

Wez: PTAL at remoting/
Ben: PTAL at google_apis/ if you can do so before joi is back on-line. Joi owns
this file, but it would be better to commit it sooner than later, and he's gone
to bed :)
joi: PTAL at google_apis/ if it's still unreviewed by the time you see this.

[Wez, 2012-09-18 01:10:36]

https://codereview.chromium.org/10939005/diff/1/remoting/webapp/build-webapp.py
File remoting/webapp/build-webapp.py (right):

https://codereview.chromium.org/10939005/diff/1/remoting/webapp/build-webapp....
remoting/webapp/build-webapp.py:29: os.path.abspath(os.path.join(sys.path[0],
'../../google_apis')))
This assumes that the path containing "google_apis" appears first in PYTHONPATH;
is that necessarily the case?

https://codereview.chromium.org/10939005/diff/1/remoting/webapp/build-webapp....
remoting/webapp/build-webapp.py:195: # TODO(jamiewalch): Get rid of the
useOfficialClientId hack.
nit: Create & refer to a bug for that work.

[Jamie, 2012-09-18 01:23:57]

https://codereview.chromium.org/10939005/diff/1/remoting/webapp/build-webapp.py
File remoting/webapp/build-webapp.py (right):

https://codereview.chromium.org/10939005/diff/1/remoting/webapp/build-webapp....
remoting/webapp/build-webapp.py:29: os.path.abspath(os.path.join(sys.path[0],
'../../google_apis')))
On 2012/09/18 01:10:36, Wez wrote:
> This assumes that the path containing "google_apis" appears first in
PYTHONPATH;
> is that necessarily the case?

It certainly appears to be when you run this using ninja. I haven't tried with
anything else. If it doesn't work, it will be a build failure, so should be easy
enough to track down.

https://codereview.chromium.org/10939005/diff/1/remoting/webapp/build-webapp....
remoting/webapp/build-webapp.py:195: # TODO(jamiewalch): Get rid of the
useOfficialClientId hack.
On 2012/09/18 01:10:36, Wez wrote:
> nit: Create & refer to a bug for that work.

Done.

[Jamie, 2012-09-18 01:33:43]

Improved comment.

[Wez, 2012-09-18 04:37:39]

lgtm

https://codereview.chromium.org/10939005/diff/3002/remoting/webapp/build-weba...
File remoting/webapp/build-webapp.py (right):

https://codereview.chromium.org/10939005/diff/3002/remoting/webapp/build-weba...
remoting/webapp/build-webapp.py:28: # sys.path[0] refers to the directory
containing this script.
nit: The first sentence explains the intent; probably don't need the second.

[Jói, 2012-09-18 09:31:39]

LGTM, thanks Jamie!

https://codereview.chromium.org/10939005/diff/3002/google_apis/google_api_key...
File google_apis/google_api_keys.py (right):

https://codereview.chromium.org/10939005/diff/3002/google_apis/google_api_key...
google_apis/google_api_keys.py:26: official_path =
os.path.join(os.path.dirname(__file__),
Thanks, my bad, sys.path[0] is only guaranteed to be the directory containing
__file__ when __name__ == '__main__' is true.

[commit-bot: I haz the power, 2012-09-18 16:59:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/10939005/3002

[commit-bot: I haz the power, 2012-09-18 19:36:34]

Change committed as 157405