Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: src/hydrogen-instructions.h

Issue 1093863002: Turn off SupportsFlexibleFloorAndRound for Arm64 due to a bug. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_HYDROGEN_INSTRUCTIONS_H_ 5 #ifndef V8_HYDROGEN_INSTRUCTIONS_H_
6 #define V8_HYDROGEN_INSTRUCTIONS_H_ 6 #define V8_HYDROGEN_INSTRUCTIONS_H_
7 7
8 #include <cstring> 8 #include <cstring>
9 #include <iosfwd> 9 #include <iosfwd>
10 10
(...skipping 2556 matching lines...) Expand 10 before | Expand all | Expand 10 after
2567 bool DataEquals(HValue* other) OVERRIDE { 2567 bool DataEquals(HValue* other) OVERRIDE {
2568 HUnaryMathOperation* b = HUnaryMathOperation::cast(other); 2568 HUnaryMathOperation* b = HUnaryMathOperation::cast(other);
2569 return op_ == b->op(); 2569 return op_ == b->op();
2570 } 2570 }
2571 2571
2572 private: 2572 private:
2573 // Indicates if we support a double (and int32) output for Math.floor and 2573 // Indicates if we support a double (and int32) output for Math.floor and
2574 // Math.round. 2574 // Math.round.
2575 bool SupportsFlexibleFloorAndRound() const { 2575 bool SupportsFlexibleFloorAndRound() const {
2576 #ifdef V8_TARGET_ARCH_ARM64 2576 #ifdef V8_TARGET_ARCH_ARM64
2577 return true; 2577 // TODO(rmcilroy): Re-enable this for Arm64 once http://crbug.com/476477 is
2578 // fixed.
2579 return false;
2578 #else 2580 #else
2579 return false; 2581 return false;
2580 #endif 2582 #endif
2581 } 2583 }
2582 HUnaryMathOperation(HValue* context, HValue* value, BuiltinFunctionId op) 2584 HUnaryMathOperation(HValue* context, HValue* value, BuiltinFunctionId op)
2583 : HTemplateInstruction<2>(HType::TaggedNumber()), op_(op) { 2585 : HTemplateInstruction<2>(HType::TaggedNumber()), op_(op) {
2584 SetOperandAt(0, context); 2586 SetOperandAt(0, context);
2585 SetOperandAt(1, value); 2587 SetOperandAt(1, value);
2586 switch (op) { 2588 switch (op) {
2587 case kMathFloor: 2589 case kMathFloor:
(...skipping 5288 matching lines...) Expand 10 before | Expand all | Expand 10 after
7876 }; 7878 };
7877 7879
7878 7880
7879 7881
7880 #undef DECLARE_INSTRUCTION 7882 #undef DECLARE_INSTRUCTION
7881 #undef DECLARE_CONCRETE_INSTRUCTION 7883 #undef DECLARE_CONCRETE_INSTRUCTION
7882 7884
7883 } } // namespace v8::internal 7885 } } // namespace v8::internal
7884 7886
7885 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 7887 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698