Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 1093843002: Revert of Introduce sys_sigprocmask and sys_sigaction. (Closed)

Created:
5 years, 8 months ago by johnme
Modified:
5 years, 8 months ago
Reviewers:
hidehiko, mdempsky
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org, jln (very slow on Chromium), Mark Seaborn, hamaji, mazda, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Introduce sys_sigprocmask and sys_sigaction. (patchset #5 id:160001 of https://codereview.chromium.org/1077143002/) Reason for revert: Tentative revert to try to fix all the failing tests on https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/2548 with stderrs like: ==22726== WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x7fb677cf3d50 in sandbox::Trap::SigSys(int, siginfo*, void*) sandbox/linux/seccomp-bpf/trap.cc:140:58 #1 0x7fb6744e3fcf in sandbox::sys_sigaction(int, sigaction const*, sigaction*) ???:0 Uninitialized value was created by an allocation of 'temp.lvalue49' in the stack frame of function '_ZN7sandbox7CodeGen6AppendEtjmm' #0 0x7fb677cf82b0 in sandbox::CodeGen::Append(unsigned short, unsigned int, unsigned long, unsigned long) sandbox/linux/bpf_dsl/codegen.cc:121:0 SUMMARY: MemorySanitizer: use-of-uninitialized-value (/b/build/slave/WebKit_Linux_MSAN/build/src/out/Release/content_shell+0xef94d50) Exiting [22595:22595:0417/081926:1015885843:ERROR:command_buffer_proxy_impl.cc(166)] Could not send GpuCommandBufferMsg_Initialize. [22595:22595:0417/081926:1015885969:ERROR:webgraphicscontext3d_command_buffer_impl.cc(209)] CommandBufferProxy::Initialize failed. [4:4:0417/081926:1015885973:ERROR:command_buffer_proxy_impl.cc(166)] Could not send GpuCommandBufferMsg_Initialize. [22595:22595:0417/081926:1015886031:ERROR:webgraphicscontext3d_command_buffer_impl.cc(226)] Failed to initialize command buffer. [4:4:0417/081926:1015886209:ERROR:webgraphicscontext3d_command_buffer_impl.cc(209)] CommandBufferProxy::Initialize failed. [4:4:0417/081926:1015886330:ERROR:webgraphicscontext3d_command_buffer_impl.cc(226)] Failed to initialize command buffer. Original issue's description: > Introduce sys_sigprocmask and sys_sigaction. > > This is preparation of nacl_helper_nonsfi's secompbpf sandbox > implementation. > PNaCl toolchain's signal ABI is incompatible with Linux's. > For example, the length of sigset_t is shoter than Linux's. > (Android has also same problem). > siginfo_t has different memory layout. > Some signal numbers, including SIGBUS, SIGCHLD and SIGSYS, > or some signal flags are different. > This CL fills the gap, by introducing linux_signal.h and > two syscalls, sys_sigprocmask and sys_sigaction. > > Also, as signal.h provides ucontext_t, but PNaCl toolchain > does not provides ucontext_t, this CL re-use the > android_ucontext.h (by renaming it to linux_ucontext.h). > > TEST=Ran bots. > BUG=358465 > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_trusty32_rel,linux_arm > > Committed: https://crrev.com/3a315e3246a5191cee27216c09e669ea2d6c33d3 > Cr-Commit-Position: refs/heads/master@{#325634} TBR=mdempsky@chromium.org,hidehiko@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=358465 Committed: https://crrev.com/290486f6ce9270fd05316988f76de73e4083e50c Cr-Commit-Position: refs/heads/master@{#325644}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -556 lines) Patch
M sandbox/linux/BUILD.gn View 1 chunk +4 lines, -5 lines 0 comments Download
M sandbox/linux/sandbox_linux.gypi View 1 chunk +5 lines, -5 lines 0 comments Download
M sandbox/linux/seccomp-bpf/die.cc View 2 chunks +1 line, -6 lines 0 comments Download
M sandbox/linux/seccomp-bpf/syscall.h View 1 chunk +5 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/trap.h View 2 chunks +3 lines, -3 lines 0 comments Download
M sandbox/linux/seccomp-bpf/trap.cc View 7 chunks +17 lines, -17 lines 0 comments Download
M sandbox/linux/services/credentials.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M sandbox/linux/services/syscall_wrappers.h View 2 chunks +0 lines, -12 lines 0 comments Download
M sandbox/linux/services/syscall_wrappers.cc View 2 chunks +0 lines, -61 lines 0 comments Download
M sandbox/linux/services/syscall_wrappers_unittest.cc View 2 chunks +0 lines, -14 lines 0 comments Download
A sandbox/linux/system_headers/android_arm64_ucontext.h View 1 chunk +29 lines, -0 lines 0 comments Download
A sandbox/linux/system_headers/android_arm_ucontext.h View 1 chunk +32 lines, -0 lines 0 comments Download
A sandbox/linux/system_headers/android_i386_ucontext.h View 1 chunk +79 lines, -0 lines 0 comments Download
A sandbox/linux/system_headers/android_mips_ucontext.h View 1 chunk +51 lines, -0 lines 0 comments Download
A sandbox/linux/system_headers/android_ucontext.h View 1 chunk +28 lines, -0 lines 0 comments Download
A sandbox/linux/system_headers/android_x86_64_ucontext.h View 1 chunk +88 lines, -0 lines 0 comments Download
D sandbox/linux/system_headers/arm64_linux_ucontext.h View 1 chunk +0 lines, -29 lines 0 comments Download
D sandbox/linux/system_headers/arm_linux_ucontext.h View 1 chunk +0 lines, -67 lines 0 comments Download
D sandbox/linux/system_headers/i386_linux_ucontext.h View 1 chunk +0 lines, -93 lines 0 comments Download
D sandbox/linux/system_headers/linux_signal.h View 1 chunk +0 lines, -73 lines 0 comments Download
D sandbox/linux/system_headers/linux_ucontext.h View 1 chunk +0 lines, -28 lines 0 comments Download
D sandbox/linux/system_headers/mips_linux_ucontext.h View 1 chunk +0 lines, -51 lines 0 comments Download
D sandbox/linux/system_headers/x86_64_linux_ucontext.h View 1 chunk +0 lines, -88 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
johnme
Created Revert of Introduce sys_sigprocmask and sys_sigaction.
5 years, 8 months ago (2015-04-17 16:02:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093843002/1
5 years, 8 months ago (2015-04-17 16:03:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-17 16:08:36 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 16:09:58 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/290486f6ce9270fd05316988f76de73e4083e50c
Cr-Commit-Position: refs/heads/master@{#325644}

Powered by Google App Engine
This is Rietveld 408576698